-
Notifications
You must be signed in to change notification settings - Fork 10
build: proxy settings for build and devcontainer #691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds proxy configuration support to the build script and development container setup, while also updating the Go version to 1.25 in the devcontainer.
Key changes:
- Added proxy environment variable handling in build.sh with fallback defaults
- Updated devcontainer to Go 1.25 with proxy configuration via runArgs
- Migrated from deprecated air package to air-verse
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| build.sh | Added proxy environment variables (HTTP_PROXY, HTTPS_PROXY, NO_PROXY) with fallback logic and passed them as build arguments to docker build |
| .devcontainer/devcontainer.json | Updated Go version to 1.25, added proxy environment variables to container runtime, and switched to air-verse package |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
.devcontainer/devcontainer.json
Outdated
| "--env", | ||
| "HTTP_PROXY=${env:http_proxy:-}", | ||
| "--env", | ||
| "HTTPS_PROXY=${env:http_proxy:-}", |
Copilot
AI
Nov 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The HTTPS_PROXY environment variable is incorrectly set to use http_proxy instead of https_proxy. This should be ${env:https_proxy:-} to properly reference the HTTPS proxy setting.
| "HTTPS_PROXY=${env:http_proxy:-}", | |
| "HTTPS_PROXY=${env:https_proxy:-}", |
.devcontainer/devcontainer.json
Outdated
| "--env", | ||
| "http_proxy=${env:http_proxy:-}", | ||
| "--env", | ||
| "https_proxy=${env:http_proxy:-}", |
Copilot
AI
Nov 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The https_proxy environment variable is incorrectly set to use http_proxy instead of https_proxy. This should be ${env:https_proxy:-} to properly reference the HTTPS proxy setting.
| "https_proxy=${env:http_proxy:-}", | |
| "https_proxy=${env:https_proxy:-}", |
9e26655 to
f348829
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #691 +/- ##
==========================================
- Coverage 42.15% 41.95% -0.20%
==========================================
Files 101 101
Lines 9519 9519
==========================================
- Hits 4013 3994 -19
- Misses 5171 5195 +24
+ Partials 335 330 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
.devcontainer/devcontainer.json
Outdated
| "--env", | ||
| "NO_PROXY=${env:no_proxy:-}", | ||
| "--env", | ||
| "http_proxy=${env:https_proxy:-}", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "http_proxy=${env:https_proxy:-}", | |
| "http_proxy=${env:http_proxy:-}", |
82355ae to
9212b1b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Want @madhavilosetty-intel and @rsdmike to review and provide a +1
9212b1b to
da4a51b
Compare
-> devcontainer go version updated to 1.25 -> devcontainer updated to include proxy settings -> build script support proxy build Signed-off-by: Nabendu Maiti <nabendu.bikash.maiti@intel.com>
da4a51b to
c38b897
Compare
rsdmike
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This results in a failure to open in a dev container:
Running the postCreateCommand from devcontainer.json...
[2263 ms] Start: Run in container: /bin/sh -c go install github.com/air-verse/air@latest
go: github.com/air-verse/air@latest: module github.com/air-verse/air: Get "https://proxy.golang.org/github.com/air-verse/air/@v/list": proxyconnect tcp: dial tcp: lookup -: no such host
What's next:
Try Docker Debug for seamless, persistent debugging tools in any container or image → docker debug 9ef79907271e520258d8993584e86b765c0191460ae0dfd9796e5aeae31cd37a
Learn more at https://docs.docker.com/go/debug-cli/
[2432 ms] postCreateCommand from devcontainer.json failed with exit code 1. Skipping any further user-provided commands.
Done. Press any key to close the terminal.
Issue #690
-> devcontainer and build.sh updated to include proxy settings
-> golang version updated to 1.25 in devcontainer