Skip to content

Conversation

@nbmaiti
Copy link

@nbmaiti nbmaiti commented Nov 4, 2025

Issue #690

-> devcontainer and build.sh updated to include proxy settings
-> golang version updated to 1.25 in devcontainer

@nbmaiti nbmaiti requested review from Copilot and rsdmike November 4, 2025 05:49
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds proxy configuration support to the build script and development container setup, while also updating the Go version to 1.25 in the devcontainer.

Key changes:

  • Added proxy environment variable handling in build.sh with fallback defaults
  • Updated devcontainer to Go 1.25 with proxy configuration via runArgs
  • Migrated from deprecated air package to air-verse

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
build.sh Added proxy environment variables (HTTP_PROXY, HTTPS_PROXY, NO_PROXY) with fallback logic and passed them as build arguments to docker build
.devcontainer/devcontainer.json Updated Go version to 1.25, added proxy environment variables to container runtime, and switched to air-verse package

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

"--env",
"HTTP_PROXY=${env:http_proxy:-}",
"--env",
"HTTPS_PROXY=${env:http_proxy:-}",
Copy link

Copilot AI Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The HTTPS_PROXY environment variable is incorrectly set to use http_proxy instead of https_proxy. This should be ${env:https_proxy:-} to properly reference the HTTPS proxy setting.

Suggested change
"HTTPS_PROXY=${env:http_proxy:-}",
"HTTPS_PROXY=${env:https_proxy:-}",

Copilot uses AI. Check for mistakes.
"--env",
"http_proxy=${env:http_proxy:-}",
"--env",
"https_proxy=${env:http_proxy:-}",
Copy link

Copilot AI Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The https_proxy environment variable is incorrectly set to use http_proxy instead of https_proxy. This should be ${env:https_proxy:-} to properly reference the HTTPS proxy setting.

Suggested change
"https_proxy=${env:http_proxy:-}",
"https_proxy=${env:https_proxy:-}",

Copilot uses AI. Check for mistakes.
@codecov
Copy link

codecov bot commented Nov 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 41.95%. Comparing base (125fbe5) to head (c38b897).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #691      +/-   ##
==========================================
- Coverage   42.15%   41.95%   -0.20%     
==========================================
  Files         101      101              
  Lines        9519     9519              
==========================================
- Hits         4013     3994      -19     
- Misses       5171     5195      +24     
+ Partials      335      330       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

"--env",
"NO_PROXY=${env:no_proxy:-}",
"--env",
"http_proxy=${env:https_proxy:-}",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"http_proxy=${env:https_proxy:-}",
"http_proxy=${env:http_proxy:-}",

@nbmaiti nbmaiti force-pushed the proxy_setting branch 2 times, most recently from 82355ae to 9212b1b Compare November 4, 2025 06:11
Copy link

@sudhir-intc sudhir-intc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Want @madhavilosetty-intel and @rsdmike to review and provide a +1

  -> devcontainer go version updated to 1.25
  -> devcontainer updated to include proxy settings
  -> build script support proxy build

Signed-off-by: Nabendu Maiti <nabendu.bikash.maiti@intel.com>
Copy link
Member

@rsdmike rsdmike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This results in a failure to open in a dev container:
Running the postCreateCommand from devcontainer.json...

[2263 ms] Start: Run in container: /bin/sh -c go install github.com/air-verse/air@latest
go: github.com/air-verse/air@latest: module github.com/air-verse/air: Get "https://proxy.golang.org/github.com/air-verse/air/@v/list": proxyconnect tcp: dial tcp: lookup -: no such host

What's next:
Try Docker Debug for seamless, persistent debugging tools in any container or image → docker debug 9ef79907271e520258d8993584e86b765c0191460ae0dfd9796e5aeae31cd37a
Learn more at https://docs.docker.com/go/debug-cli/
[2432 ms] postCreateCommand from devcontainer.json failed with exit code 1. Skipping any further user-provided commands.
Done. Press any key to close the terminal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants