Skip to content

fix: enable local transport fallback for TLS when LMS is missing #1084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
nbmaiti wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

fix: enable local transport fallback for TLS when LMS is missing #1084

nbmaiti wants to merge 2 commits into from

Conversation

@nbmaiti
Copy link

@nbmaiti nbmaiti commented Jan 7, 2026 

Updates WSMAN setup to fallback to local HECI transport if the LMS
TLS port (16993) is unreachable.

Fixes WSMAN client failures on platforms without LMS (driver-only),
enabling CCM/ACM activation and upgrades over TLS via LME.

Files:
    - internal/local/amt/wsman.go: Added TLS fallback logic.

Resolves #909

@nbmaiti nbmaiti requested a review from rsdmike January 7, 2026 07:49
@nbmaiti
fix: enable local transport fallback for TLS when LMS is missing
ae90a0e 
    Updates WSMAN setup to fallback to local HECI transport if the LMS
    TLS port (16993) is unreachable.

    Fixes WSMAN client failures on platforms without LMS (driver-only),
    enabling CCM/ACM activation and upgrades over TLS via LME.

    Files:
        - internal/local/amt/wsman.go: Added TLS fallback logic.

    Resolves #909

Signed-off-by: Nabendu Maiti <nabendu.bikash.maiti@intel.com>
@nbmaiti nbmaiti force-pushed the lme_support_tls branch 2 times, most recently from 295be87 to ae90a0e Compare January 7, 2026 07:55
rsdmike
rsdmike requested changes Jan 7, 2026
View reviewed changes
Copy link
Member

@rsdmike rsdmike left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you attach a screenshot with -v of the output when running these changes. Either an activate or deactivate on an AMT 19 machine showing success? For me the device hangs:

C:\Users\amt\Development\rpc-go>go run ./cmd/rpc/main.go deactivate --local  -v
time="2026-01-07T12:52:49-07:00" level=trace msg="Running AfterApply for AMTBaseCmd"
time="2026-01-07T12:52:49-07:00" level=info msg="TLS is enforced on local ports"
AMT Password:
time="2026-01-07T12:52:52-07:00" level=trace msg="Setting default TLS Config for ACM/CCM mode"
time="2026-01-07T12:52:52-07:00" level=info msg="Failed to connect to LMS, using local transport instead."
time="2026-01-07T12:52:52-07:00" level=debug msg="sending APF_PROTOCOL_VERSION_MESSAGE"
time="2026-01-07T12:52:52-07:00" level=debug msg="Sending SystemId UUID: 00000000-0000-0000-0000-000000000000"
time="2026-01-07T12:52:52-07:00" level=trace msg="{MessageType:192 MajorVersion:1 MinorVersion:0 TriggerReason:9 UUID:[0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0] Reserved:[0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0]}"
time="2026-01-07T12:52:52-07:00" level=debug msg="received APF PROTOCOL VERSION"
time="2026-01-07T12:52:52-07:00" level=debug msg="SystemId UUID: EAC2D203-FF81-439A-9EF0-A63084B5818E"
time="2026-01-07T12:52:52-07:00" level=trace msg="{MessageType:192 MajorVersion:1 MinorVersion:0 TriggerReason:254 UUID:[3 210 194 234 129 255 154 67 158 240 166 48 132 181 129 142] Reserved:[0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0]}"
time="2026-01-07T12:52:52-07:00" level=debug msg="sending APF_PROTOCOL_VERSION_MESSAGE"
time="2026-01-07T12:52:52-07:00" level=debug msg="Sending SystemId UUID: EAC2D203-FF81-439A-9EF0-A63084B5818E"
time="2026-01-07T12:52:52-07:00" level=trace msg="{MessageType:192 MajorVersion:1 MinorVersion:0 TriggerReason:254 UUID:[3 210 194 234 129 255 154 67 158 240 166 48 132 181 129 142] Reserved:[0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0]}"
time="2026-01-07T12:52:52-07:00" level=debug msg="received APF_SERVICE_REQUEST"
time="2026-01-07T12:52:52-07:00" level=trace msg="{MessageType:5 ServiceNameLength:18 ServiceName:pfwd@amt.intel.com}"
time="2026-01-07T12:52:52-07:00" level=debug msg="sending APF_SERVICE_ACCEPT_MESSAGE"
time="2026-01-07T12:52:52-07:00" level=trace msg="{MessageType:6 ServiceNameLength:18 ServiceName:[112 102 119 100 64 97 109 116 46 105 110 116 101 108 46 99 111 109]}"
time="2026-01-07T12:52:52-07:00" level=debug msg="received APF_GLOBAL_REQUEST"
time="2026-01-07T12:52:52-07:00" level=trace msg="{MessageType:80 StringLength:13 String:tcpip-forward}"
time="2026-01-07T12:52:52-07:00" level=trace msg="{WantReply:1 AddressLength:0 Address: Port:16993}"
time="2026-01-07T12:52:52-07:00" level=debug msg="sending APF_TCP_FORWARD_REPLY_MESSAGE"
time="2026-01-07T12:52:52-07:00" level=trace msg="{MessageType:81 PortBound:16993}"
time="2026-01-07T12:52:52-07:00" level=debug msg="received APF_GLOBAL_REQUEST"
time="2026-01-07T12:52:52-07:00" level=trace msg="{MessageType:80 StringLength:13 String:tcpip-forward}"
time="2026-01-07T12:52:52-07:00" level=trace msg="{WantReply:1 AddressLength:0 Address: Port:664}"
time="2026-01-07T12:52:52-07:00" level=debug msg="sending APF_TCP_FORWARD_REPLY_MESSAGE"
time="2026-01-07T12:52:52-07:00" level=trace msg="{MessageType:81 PortBound:664}"
exit status 0xc000013a

C:\Users\amt\Development\rpc-go>go run ./cmd/rpc/main.go deactivate --local  -v

Really, #1082 needs to be resolved before this can be adequately tested as mentioned in the description of the story.

Thanks!

@nbmaiti nbmaiti marked this pull request as draft January 12, 2026 15:44
@sudhir-intc
Copy link

sudhir-intc commented Feb 2, 2026

Can you attach a screenshot with -v of the output when running these changes. Either an activate or deactivate on an AMT 19 machine showing success? For me the device hangs:

C:\Users\amt\Development\rpc-go>go run ./cmd/rpc/main.go deactivate --local  -v
time="2026-01-07T12:52:49-07:00" level=trace msg="Running AfterApply for AMTBaseCmd"
time="2026-01-07T12:52:49-07:00" level=info msg="TLS is enforced on local ports"
AMT Password:
time="2026-01-07T12:52:52-07:00" level=trace msg="Setting default TLS Config for ACM/CCM mode"
time="2026-01-07T12:52:52-07:00" level=info msg="Failed to connect to LMS, using local transport instead."
time="2026-01-07T12:52:52-07:00" level=debug msg="sending APF_PROTOCOL_VERSION_MESSAGE"
time="2026-01-07T12:52:52-07:00" level=debug msg="Sending SystemId UUID: 00000000-0000-0000-0000-000000000000"
time="2026-01-07T12:52:52-07:00" level=trace msg="{MessageType:192 MajorVersion:1 MinorVersion:0 TriggerReason:9 UUID:[0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0] Reserved:[0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0]}"
time="2026-01-07T12:52:52-07:00" level=debug msg="received APF PROTOCOL VERSION"
time="2026-01-07T12:52:52-07:00" level=debug msg="SystemId UUID: EAC2D203-FF81-439A-9EF0-A63084B5818E"
time="2026-01-07T12:52:52-07:00" level=trace msg="{MessageType:192 MajorVersion:1 MinorVersion:0 TriggerReason:254 UUID:[3 210 194 234 129 255 154 67 158 240 166 48 132 181 129 142] Reserved:[0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0]}"
time="2026-01-07T12:52:52-07:00" level=debug msg="sending APF_PROTOCOL_VERSION_MESSAGE"
time="2026-01-07T12:52:52-07:00" level=debug msg="Sending SystemId UUID: EAC2D203-FF81-439A-9EF0-A63084B5818E"
time="2026-01-07T12:52:52-07:00" level=trace msg="{MessageType:192 MajorVersion:1 MinorVersion:0 TriggerReason:254 UUID:[3 210 194 234 129 255 154 67 158 240 166 48 132 181 129 142] Reserved:[0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0]}"
time="2026-01-07T12:52:52-07:00" level=debug msg="received APF_SERVICE_REQUEST"
time="2026-01-07T12:52:52-07:00" level=trace msg="{MessageType:5 ServiceNameLength:18 ServiceName:pfwd@amt.intel.com}"
time="2026-01-07T12:52:52-07:00" level=debug msg="sending APF_SERVICE_ACCEPT_MESSAGE"
time="2026-01-07T12:52:52-07:00" level=trace msg="{MessageType:6 ServiceNameLength:18 ServiceName:[112 102 119 100 64 97 109 116 46 105 110 116 101 108 46 99 111 109]}"
time="2026-01-07T12:52:52-07:00" level=debug msg="received APF_GLOBAL_REQUEST"
time="2026-01-07T12:52:52-07:00" level=trace msg="{MessageType:80 StringLength:13 String:tcpip-forward}"
time="2026-01-07T12:52:52-07:00" level=trace msg="{WantReply:1 AddressLength:0 Address: Port:16993}"
time="2026-01-07T12:52:52-07:00" level=debug msg="sending APF_TCP_FORWARD_REPLY_MESSAGE"
time="2026-01-07T12:52:52-07:00" level=trace msg="{MessageType:81 PortBound:16993}"
time="2026-01-07T12:52:52-07:00" level=debug msg="received APF_GLOBAL_REQUEST"
time="2026-01-07T12:52:52-07:00" level=trace msg="{MessageType:80 StringLength:13 String:tcpip-forward}"
time="2026-01-07T12:52:52-07:00" level=trace msg="{WantReply:1 AddressLength:0 Address: Port:664}"
time="2026-01-07T12:52:52-07:00" level=debug msg="sending APF_TCP_FORWARD_REPLY_MESSAGE"
time="2026-01-07T12:52:52-07:00" level=trace msg="{MessageType:81 PortBound:664}"
exit status 0xc000013a

C:\Users\amt\Development\rpc-go>go run ./cmd/rpc/main.go deactivate --local  -v

Really, #1082 needs to be resolved before this can be adequately tested as mentioned in the description of the story.

Thanks!

Device getting hung is due to the issue # #1119

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rsdmike rsdmike rsdmike requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nbmaiti @sudhir-intc @rsdmike