refactor: Add CIRA log retrieval command #1114
Conversation
There was a problem hiding this comment.
Pull request overview
This PR implements a new ciralog command to retrieve CIRA (Client Initiated Remote Access) connection logs and status information from Intel AMT devices via the PTHI interface.
Changes:
- Added PTHI message types and data structures for CIRA log retrieval
- Implemented GetCiraLog command in AMT and PTHI packages
- Created ciralog command with JSON and text output formatting
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/pthi/types.go | Defines CIRA log request/response constants and extensive data structures for log entries |
| pkg/pthi/commands.go | Implements GetCiraLog method with binary serialization/deserialization logic |
| pkg/amt/commands.go | Adds AMT-level GetCiraLog wrapper with PTHI interface handling |
| internal/commands/ciralog.go | Implements user-facing command with formatting helpers and output functions |
| internal/cli/cli.go | Registers new ciralog command in CLI |
| pkg/amt/commands_test.go | Adds mock implementation for testing |
| internal/rps/message_test.go | Adds mock implementation for testing |
| internal/mocks/amt_mock.go | Adds generated mock method |
| internal/commands/activate/local_test.go | Adds mock implementation for testing |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
internal/commands/ciralog.go
Outdated
| fmt.Printf("\tIsTunnelOpened(0-Closed, 1-Opened) = %d\n", result.CiraStatusSummary.IsTunnelOpened) | ||
| fmt.Printf("\tCurrentConnectionState = %d (%s)\n", result.CiraStatusSummary.CurrentConnectionState, | ||
| getConnectionStateString(result.CiraStatusSummary.CurrentConnectionState)) | ||
| fmt.Printf("\tLastKeepAlive(The time in which the last keepalive message was sent, 0 if not curently connected) = %d(%s)\n", |
There was a problem hiding this comment.
Corrected spelling of 'curently' to 'currently'.
| fmt.Printf("\tLastKeepAlive(The time in which the last keepalive message was sent, 0 if not curently connected) = %d(%s)\n", | |
| fmt.Printf("\tLastKeepAlive(The time in which the last keepalive message was sent, 0 if not currently connected) = %d(%s)\n", |
There was a problem hiding this comment.
Updated. Thanks.
|
|
||
| func formatIPv4(ip uint32) string { | ||
| if ip == 0 { | ||
| return zeroIP |
There was a problem hiding this comment.
The constant 'zeroIP' is referenced but not defined in this file. Either define it as a constant (e.g., const zeroIP = \"0.0.0.0\") or replace the reference with the literal string.
There was a problem hiding this comment.
It is defined in amtinfo.go which is under the same commands package.
rpc-go/internal/commands/amtinfo.go
Line 34 in f7127fb
pkg/pthi/commands.go
Outdated
| Version: 0, | ||
| } | ||
|
|
||
| var bin_buf bytes.Buffer |
There was a problem hiding this comment.
Variable name 'bin_buf' uses snake_case which is inconsistent with Go naming conventions. Rename to 'binBuf' to follow camelCase.
There was a problem hiding this comment.
Updated. Thanks.
sinchubhat
force-pushed
the
issue1003-rpc-go
branch
3 times, most recently
from
c553666 to
b00d0c8
Compare
sinchubhat
changed the title
sinchubhat
force-pushed
the
issue1003-rpc-go
branch
from
b00d0c8 to
3fa4c0b
Compare
Implements the rpc cira-log command to retrieve CIRA (Client Initiated Remote Access) connection logs and status from Intel AMT via PTHI interface. Resolves #1003
sinchubhat
force-pushed
the
issue1003-rpc-go
branch
2 times, most recently
from
453193c to
11b8c8b
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 9 out of 9 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sinchubhat
force-pushed
the
issue1003-rpc-go
branch
from
11b8c8b to
5377143
Compare
1 participant
Implements the rpc cira-log command to retrieve CIRA (Client Initiated Remote Access) connection logs and status from Intel AMT via PTHI interface.
Resolves #1003