Skip to content

Conversation

@rsdmike
Copy link
Member

@rsdmike rsdmike commented Feb 2, 2026

No description provided.

Copilot AI review requested due to automatic review settings February 2, 2026 20:03
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds password confirmation functionality for AMT password prompts during device activation. When a device is not yet activated (control mode 0), users must now confirm their password to prevent typos during the initial setup process.

Changes:

  • Added ReadPasswordWithConfirmation method to the PasswordReader interface
  • Modified EnsureAMTPassword to require password confirmation for non-activated devices
  • Updated all mock implementations of PasswordReader to include the new method

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.

Show a summary per file
File Description
pkg/utils/passwordReader.go Adds ReadPasswordWithConfirmation method to interface and implements password confirmation logic
pkg/utils/passwordReader_test.go Provides test coverage for the new password confirmation functionality
internal/commands/base.go Updates EnsureAMTPassword to conditionally prompt for password confirmation based on control mode
internal/commands/base_test.go Expands test cases to cover password confirmation scenarios for different control modes
internal/commands/activate/activate_test.go Updates mock to implement new interface method
internal/commands/configure/cira_test.go Updates mock to implement new interface method
internal/commands/deactivate_test.go Updates mock to implement new interface method
internal/rps/message_test.go Updates mock to implement new interface method
pkg/smb/samba_test.go Updates mock to implement new interface method
internal/cli/integration_test.go Updates mock to implement new interface method

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant