-
Notifications
You must be signed in to change notification settings - Fork 21
feat: add devcontainer #1141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: add devcontainer #1141
Conversation
-> Add devcontainer configuration for development environment setup. -> Added go debug -> Updated launch.json for go debug configuration. Signed-off-by: Nabendu Maiti <nabendu.bikash.maiti@intel.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds devcontainer configurations to standardize the development environment for the project. It includes setup for both standard and MEI device development scenarios, along with improved Go debugging capabilities.
Changes:
- Added two devcontainer configurations: one for standard development without MEI device and one for MEI device development on Linux hosts
- Enhanced VS Code launch configurations with dynamic input variables for server address, profile name, and DNS suffix
- Removed
asRootparameter from all Go debug configurations in launch.json
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| .vscode/launch.json | Updated Go debug configurations to use input variables and removed deprecated asRoot settings |
| .devcontainer/standard/devcontainer.json | Added standard devcontainer configuration with Go 1.25 and proxy support |
| .devcontainer/pre-create.sh | Added pre-creation script to check/install Intel LMS service on the host |
| .devcontainer/post-create.sh | Added post-creation script for proxy configuration and Go tool installation |
| .devcontainer/mei/devcontainer.json | Added MEI device devcontainer with privileged access and host networking |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # Remove all trailing / or \ | ||
| url="${url%%*(/|\\)}" | ||
| # Fallback for Bash < 4.0 (no extglob): use sed |
Copilot
AI
Feb 4, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This extended glob pattern syntax requires shopt -s extglob to be enabled, but the script doesn't set it. The pattern *(/|\\) will not work as intended without extglob. Either add shopt -s extglob at the beginning of the script or rely solely on the sed fallback on line 16.
| # Remove all trailing / or \ | |
| url="${url%%*(/|\\)}" | |
| # Fallback for Bash < 4.0 (no extglob): use sed | |
| # Remove all trailing / or \ using sed |
| "runArgs": [ | ||
| "--device", | ||
| "/dev/mei0", | ||
| "--privileged", |
Copilot
AI
Feb 4, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Running the container with --privileged grants extensive permissions that may not all be necessary. Consider using more specific capabilities instead (e.g., --cap-add for required capabilities) to follow the principle of least privilege.
| "--privileged", |
|
Thanks for doing this @nbmaiti! One suggestion to make this easier to review, it might help to split this into two PRs.
For the |
-> Add devcontainer configuration for development environment setup.
-> Added go debug
-> Updated launch.json for go debug configuration.