add AWS plugin for AWS MSK's IAM access control #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| signedAt, err := time.Parse("20060102T150405Z", d) | ||
| if err != nil { | ||
| return false, fmt.Errorf("failed to parse the 'X-Amz-Date' param from signed url: %w", err) |
There was a problem hiding this comment.
Note
Unlike ExpiresQueryKey, this string is not exposed.
Ref: aws/aws-msk-iam-sasl-signer-go#19
Signed-off-by: KeisukeYamashita <19yamashita15@gmail.com>
KeisukeYamashita
force-pushed
the
add-aws-plugin
branch
from
4bcad31 to
a249228
Compare
|
@KeisukeYamashita thank you again for the PR. I added some smaller adjustments, but in general everything looked fine 💯 I will build a release for this, by the end of today hopefully. |
|
@d-rk Sorry for the late reply 🙏 Thank you very much for your review and the release 🚀 |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implemented a token provider plugin using IAM access control to enable access to MSK without static credentials such as passwords. With this implementation, users can execute
kafkactlwith IAM access control, eliminating the need to manage IDs and passwords.Previously, as described in the issue below, operators and administrators had to enable
SASL/SCRAMauthentication or perform cumbersome operations due tokafkactlnot supporting IAM access control for AWS MSK. This implementation simplifies the process and enhances security.Fixes deviceinsight/kafkactl#152
I would like to update the deviceinsight/kafkactl documentation after this plugin gets approved and released.
Type of change
Please delete options that are not relevant.
Documentation
## [Unreleased]section of<plugin>/CHANGELOG.md<plugin>/README.adocwere updated