-
Notifications
You must be signed in to change notification settings - Fork 454
Add tvOS support for volume capacity properties #455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Co-authored-by: Zandor300 <6069593+Zandor300@users.noreply.github.com>
@copilot Run gyb with flag " --line-directive '' to get rid of the "sourceLocation" lines in the generated swift file. Update your own instructions to include that by default. |
…e-directive flag Co-authored-by: Zandor300 <6069593+Zandor300@users.noreply.github.com>
Updated the generated Swift file to remove sourceLocation lines using |
SwiftLint found issuesWarnings
Generated by 🚫 Danger |
tvOS build failed: Test session results, code coverage, and logs:
** TEST FAILED ** |
…properties for both iOS and tvOS Co-authored-by: Zandor300 <6069593+Zandor300@users.noreply.github.com>
Fixed the tvOS build errors. The advanced volume capacity properties (volumeAvailableCapacityForImportantUsage, volumeAvailableCapacityForOpportunisticUsage, and volumes) use resource keys that are unavailable on tvOS, so I've restricted them to iOS-only. Basic volume properties (volumeTotalCapacity and volumeAvailableCapacity) remain available on both iOS and tvOS. (cab5466) |
#if os(iOS)
to#if os(iOS) || os(tvOS)
for basic volume propertiesChanges made:
Technical details:
volumeAvailableCapacityForImportantUsageKey
andvolumeAvailableCapacityForOpportunisticUsageKey
are unavailable in tvOSFixes #449.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.