Added in support for Gitbash on Windows OS #31
Conversation
| if [[ "$OSTYPE" == "msys"* ]] | ||
| then | ||
| FILESUM=$(certutil -hashfile $0 sha256 | tail -n2 | head -n1) | ||
| EXPECTEDSUM=$(curl -sL "$SUMPATH" | sed 's/ -//') # ⚠️ additional 2xspace + dash may also need to be addressed on unix installs |
There was a problem hiding this comment.
This was interesting as I noticed the additional spaces and dash being appended to $EXPECTEDSUM coming from the $SUMPATH request. I don't have a lot of experience in bash so this may be expected in the Unix environment. Specifically when using shasum. Just thought I'd call it out that I had to strip these appended characters in order to accurately compare the file downloaded to the expected checksum.
|
Thanks for the PR. I'll try and get to it in the next day or so. I'll stand up a VM to test as well. |
Thank you! No rush at all. |
gvm
Outdated
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| ############################################################################### | |||
| # GENERATED VERSION! DO NOT CHANGE! # | |||
| SCRIPTVERSION="local-dev" | |||
| SCRIPTVERSION="latest" | |||
There was a problem hiding this comment.
Can you update this to local-dev? The script version should be local-dev for changes. It's updated by the CI/CD pipeline to match the tagged version prior to generating the sum file for comparison on update.
There was a problem hiding this comment.
No problem. Just updated in latest commit.
Script version should read local-dev for any changes. This is in support of the CI/CD pipeline.
|
@jdaniel-cpts Weekend ended up busier than expected. Will try and get to this this week. Sorry for the delay. |
No problem! |
Description
Link to Feature Request: #30
New Feature: Ability for gvm to support Gitbash running on Windows OS. (64bit Windows)
Examples
Sample Run below of a simple go version switch (all credit to the gvm team, this is simply a port to Windows + Gitbash)
In order to test make sure you are running a modern version of Windows i.e. Windows 10 64bit.
Install Gitbash: https://www.makeuseof.com/install-git-git-bash-windows/ ( ✔️ Make sure you allow symlinks during install because gvm depends on it to link user to the elected version of go).