#712: Azure CLI integration #741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add configuration file in azurecli.asciidoc
|
|
github-actions
bot
added
bash
Closed
12 tasks
tobka777
requested changes
May 13, 2022
There was a problem hiding this comment.
Good work!
I have added some comments that you are welcome to implement or even discuss if you see something differently.
Please still agree with the Constribution Guildlines.
Please also check the shellchecker. There is one error.
hohwille
changed the title
tobka777
approved these changes
May 19, 2022
hohwille
requested changes
May 23, 2022
There was a problem hiding this comment.
@alfeilex Thanks for this PR. You have done a very good job and it is more or less ready to be merged. Some of my comments are rather picky and are just nice-to-have hints for you. I would have merged right away but the last 2 comments seem to require a little improvement.
hohwille
reviewed
May 23, 2022
hohwille
reviewed
May 23, 2022
|
@hohwille I have applied the changes. The code is now more compact. Thank you for the comments. |
hohwille
reviewed
May 30, 2022
hohwille
reviewed
May 30, 2022
hohwille
reviewed
May 30, 2022
hohwille
reviewed
May 30, 2022
hohwille
reviewed
May 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Azure CLI can be installed in Windows via Command
devon az