Merge pull request #348 from vbakke/fix/348-modal-sideeffect

Remove sideeffect when opening modal dialog
devsecopsmaturitymodel · Jan 13, 2025 · fd118d7 · fd118d7
2 parents 6a2f02d + e4a1abc
commit fd118d7
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/src/app/component/circular-heatmap/circular-heatmap.component.html b/src/app/component/circular-heatmap/circular-heatmap.component.html
@@ -251,7 +251,7 @@ <h2>Nothing to show</h2>
                       class="title-button"
                       (click)="
                         $event.preventDefault();
-                        navigate(
+                        openActivityDetails(
                           currentDimension,
                           cardHeader,
                           activity['activityName']

diff --git a/src/app/component/circular-heatmap/circular-heatmap.component.ts b/src/app/component/circular-heatmap/circular-heatmap.component.ts
@@ -717,21 +717,21 @@ export class CircularHeatmapComponent implements OnInit {
     }
   }
 
-  navigate(dim: string, subdim: string, activityName: string) {
+  openActivityDetails(dim: string, subdim: string, activityName: string) {
     let navigationExtras = {
       dimension: dim,
       subDimension: subdim,
       activityName: activityName,
     };
-    this.yaml.setURI('./assets/YAML/generated/generated.yaml');
-    this.activityDetails = this.YamlObject[dim][subdim][activityName];
-    console.log(this.YamlObject);
-    console.log(this.YamlObject[dim][subdim]);
+    this.activityDetails = Object.assign(
+      {},
+      this.YamlObject[dim][subdim][activityName]
+    );
+
     if (this.activityDetails) {
       this.activityDetails.navigationExtras = navigationExtras;
     }
     console.log(this.activityDetails);
-    console.log(this.ALL_CARD_DATA);
     this.showOverlay = true;
   }