Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add openCRE #260

Merged
merged 3 commits into from
Nov 23, 2023
Merged

feat: add openCRE #260

merged 3 commits into from
Nov 23, 2023

Conversation

wurstbrot
Copy link
Collaborator

No description provided.

@wurstbrot wurstbrot requested a review from 0x41head November 15, 2023 12:39
@0x41head
Copy link
Collaborator

@wurstbrot can you make the relevant change in the YAML file, to test this change out locally ?

@0x41head
Copy link
Collaborator

@wurstbrot the changes made do not break anything, but nothing is reflected on the frontend either. Is this the intended result ?

@wurstbrot
Copy link
Collaborator Author

@wurstbrot the changes made do not break anything, but nothing is reflected on the frontend either. Is this the intended result ?

thank you for testing, I messed it up. Made it work here (incl. test)

Copy link
Collaborator

@0x41head 0x41head left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@wurstbrot wurstbrot merged commit 022f03a into master Nov 23, 2023
4 checks passed
@wurstbrot wurstbrot deleted the feat/openCRE branch November 23, 2023 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants