Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(be): Add support for new degrees #1151

Merged
merged 5 commits into from
Oct 17, 2024
Merged

Conversation

lhvy
Copy link
Contributor

@lhvy lhvy commented Jun 14, 2024

  • Add support for Advanced Computer Science
  • Prepare to add support for City Planning (Honours)

Note that City Planning is still hidden because the Degree Wizard is unable to cope with degrees that do not have any specialisations. I have made it clearer where this problem lies, but we do not have time to fix it currently.

@lhvy lhvy added the 📝 feature 🧠 New feature or request label Jun 14, 2024
@lhvy lhvy self-assigned this Jun 14, 2024
@lhvy lhvy requested a review from a team as a code owner June 14, 2024 07:23
@lhvy lhvy changed the title feat(all): Add support for Advanced Computer Science degree feat(be): Add support for Advanced Computer Science degree Jun 14, 2024
Copy link

github-actions bot commented Jun 14, 2024

Test Results

156 tests  ±0   80 ✅ ±0   42s ⏱️ +3s
 13 suites ±0    2 💤 ±0 
  2 files   ±0   74 ❌ ±0 

For more details on these failures, see this check.

Results for commit 06b427f. ± Comparison against base commit f142dab.

♻️ This comment has been updated with latest results.

@lhvy lhvy force-pushed the fe/be/add-adv-cs-degree branch 2 times, most recently from e6027ee to 21056ce Compare July 6, 2024 07:38
@ollibowers
Copy link
Collaborator

👿

@ollibowers
Copy link
Collaborator

(i will rework degree wizard a bit before this goes in)

@lhvy lhvy changed the title feat(be): Add support for Advanced Computer Science degree feat(be): Add support for new degrees Aug 2, 2024
@lhvy lhvy force-pushed the fe/be/add-adv-cs-degree branch 2 times, most recently from 1af2331 to 2ca7442 Compare September 5, 2024 13:52
@lhvy lhvy enabled auto-merge (squash) October 16, 2024 14:33
Copy link
Contributor

@martanman martanman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lhvy lhvy merged commit a3b127a into 331-staging Oct 17, 2024
8 checks passed
@lhvy lhvy deleted the fe/be/add-adv-cs-degree branch October 17, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📝 feature 🧠 New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants