Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated it with new changes from other people #343

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

RichardBao1
Copy link
Contributor

hopefully this works

Copy link
Contributor

@matth3wliuu matth3wliuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good. Also, a good idea to change the name of the pr to something that matches what you've implemented so, everyone knows what this pr is for.

I will investigate what's up with the decryption thing before we merge this in 😄

@@ -86,6 +87,11 @@ interface Year {
year: string;
}

interface VerifyBody {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VerifyTokenBody might be a clearer name for this

res: Response,
next: NextFunction,
) {
// const encodedJwt = req.body.jwt;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: remove commented out code

@@ -470,6 +471,15 @@ app.get(
Middleware.genericLoggingMiddleware,
);

app.get(
'/check-token-valid',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

auth/verify/token might be a clearer name for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants