Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Derek/JOB-164 BE Company Verification System #404

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from

Conversation

derekxu04
Copy link
Contributor

@derekxu04 derekxu04 commented Oct 8, 2023

  • Added verifiedCompaniesAddresses column to AdminAccount entity
  • Implemented GET route /admin/verified-companies-addresses and tests
  • Implemented POST route /admin/verified-companies-addresses/add and tests
  • Implemented POST route /admin/verified-companies-addresses/delete and tests (POST works better here i think vs DELETE because it can have a request body)
  • Updated backend documentation
  • Made sure all functions in admin.ts return a new web token (not msg: undefined)

Incomplete:

  • I haven't modified CompanyFunction.CreateCompany to return verified: true/false yet - wouldn't that require an adminId to query the database with? Or do I just get the first adminAccount or something

Notes:

  • How many admin accounts are there? Because, for example, adding addresses right now is only adding the addresses to one of the AdminAccounts rather than all of them
  • Some of my unit tests that require two api calls (one for adding, one for getting to check that it was actually added) look a bit funky - is there a better way?

@derekxu04 derekxu04 changed the title DRAFT: Derek/job 164 be company verification system Derek/JOB-164 BE Company Verification System Oct 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant