Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency nodemailer to v6.9.9 [security] #429

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Feb 5, 2024

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
nodemailer (source) 6.9.5 -> 6.9.9 age adoption passing confidence

GitHub Vulnerability Alerts

GHSA-9h6g-pr28-7cqp

Summary

A ReDoS vulnerability occurs when nodemailer tries to parse img files with the parameter attachDataUrls set, causing the stuck of event loop.
Another flaw was found when nodemailer tries to parse an attachments with a embedded file, causing the stuck of event loop.

Details

Regex: /^data:((?:[^;];)(?:[^,])),(.)$/

Path: compile -> getAttachments -> _processDataUrl

Regex: /(<img\b[^>]* src\s*=[\s"']*)(data:([^;]+);[^"'>\s]+)/

Path: _convertDataImages

PoC

https://gist.github.com/francoatmega/890dd5053375333e40c6fdbcc8c58df6
https://gist.github.com/francoatmega/9aab042b0b24968d7b7039818e8b2698

Impact

ReDoS causes the event loop to stuck a specially crafted evil email can cause this problem.


Release Notes

nodemailer/nodemailer (nodemailer)

v6.9.9

Compare Source

Bug Fixes
  • security: Fix issues described in GHSA-9h6g-pr28-7cqp. Do not use eternal matching pattern if only a few occurences are expected (dd8f5e8)
  • tests: Use native node test runner, added code coverage support, removed grunt (#​1604) (be45c1b)

v6.9.8

Compare Source

Bug Fixes
  • punycode: do not use native punycode module (b4d0e0c)

v6.9.7

Compare Source

Bug Fixes
  • customAuth: Do not require user and pass to be set for custom authentication schemes (fixes #​1584) (41d482c)

v6.9.6

Compare Source

Bug Fixes
  • inline: Use 'inline' as the default Content Dispostion value for embedded images (db32c93)
  • tests: Removed Node v12 from test matrix as it is not compatible with the test framework anymore (7fe0a60)

Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

Copy link
Contributor Author

renovate bot commented Feb 5, 2024

Branch automerge failure

This PR was configured for branch automerge. However, this is not possible, so it has been raised as a PR instead.

@renovate renovate bot added the dependencies Pull requests that update a dependency file label Feb 5, 2024
@renovate renovate bot requested a review from a team as a code owner February 5, 2024 04:37
@renovate renovate bot force-pushed the renovate/npm-nodemailer-vulnerability branch 2 times, most recently from f01b9d0 to d246685 Compare February 19, 2024 03:02
@renovate renovate bot force-pushed the renovate/npm-nodemailer-vulnerability branch from d246685 to 8c1da33 Compare March 30, 2024 06:02
@renovate renovate bot force-pushed the renovate/npm-nodemailer-vulnerability branch from 8c1da33 to 90e9dff Compare April 19, 2024 12:55
@renovate renovate bot force-pushed the renovate/npm-nodemailer-vulnerability branch 2 times, most recently from ad4e608 to 60c1e9a Compare May 25, 2024 05:57
@renovate renovate bot force-pushed the renovate/npm-nodemailer-vulnerability branch from 60c1e9a to 8dc47e4 Compare June 12, 2024 23:00
@renovate renovate bot force-pushed the renovate/npm-nodemailer-vulnerability branch 4 times, most recently from 445463a to 33b510f Compare June 26, 2024 06:17
@renovate renovate bot force-pushed the renovate/npm-nodemailer-vulnerability branch 2 times, most recently from 5ed165b to 6e036de Compare July 19, 2024 08:52
@renovate renovate bot force-pushed the renovate/npm-nodemailer-vulnerability branch 2 times, most recently from 2efaa86 to 9fe4b37 Compare July 28, 2024 11:43
@renovate renovate bot force-pushed the renovate/npm-nodemailer-vulnerability branch from 9fe4b37 to 34a6c28 Compare September 5, 2024 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file deps: javascript deps: patches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants