Fixed quorum fishing attack #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Arvolear
commented
Jun 3, 2024
•
Arvolear
commented
- Since this PR suggests a bug fix, the tests have been added and the coverage is 100%.
- Since this PR introduces a new feature, the update has been discussed in an Issue or with the team.
- This PR is just a minor change, like a typo fix.
todesstille
added a commit
that referenced
this pull request
Oct 3, 2024
* amoy settings * try execute in lib * tryExecute * refactor * amoy settings (#198) * amoy settings (#198) (#200) * Network/optimism (#202) * env parameters * removed duplicated network * Dev (#203) (#204) * amoy settings (#198) * Network/optimism (#202) * env parameters * removed duplicated network * gas amount (#205) * 20k gas (#207) * revert just in case (#208) * gas 30k (#209) * Networks/base sepolia (#212) * initial settings * verify parameters and token addresses * final properties * Fixed quorum fishing attack (#210) * fixed solidity todo tests * regression test * naming * fix tests coverage (#214) --------- Co-authored-by: Dmitry Redkin <tanatonaut@gmail.com> Co-authored-by: todesstille <87335281+todesstille@users.noreply.github.com> * Feature/token preallocation (#213) * allocation added * refactored * tests * environment proxy and tests * govpool preallocation * fixes * added allocator and payee roles * metadata * view functions * added auxiliary contracts deploy * dependand * tx.origin * unlock in multiplier * function annotations * fixes * fixes * Feature/token factory (#215) * predeploy token * handle invalid deploy * integrated with allocator * token allocator integration * Feature/gov tokens (#216) * burnable pausable * capped * tokens * removed old tests * fixes (#217) * revards 1/100 --------- Co-authored-by: Artem Chystiakov <47551140+Arvolear@users.noreply.github.com>
todesstille
added a commit
that referenced
this pull request
Dec 13, 2024
* amoy settings * try execute in lib * tryExecute * refactor * amoy settings (#198) * amoy settings (#198) (#200) * Network/optimism (#202) * env parameters * removed duplicated network * Dev (#203) (#204) * amoy settings (#198) * Network/optimism (#202) * env parameters * removed duplicated network * gas amount (#205) * 20k gas (#207) * revert just in case (#208) * gas 30k (#209) * Networks/base sepolia (#212) * initial settings * verify parameters and token addresses * final properties * Fixed quorum fishing attack (#210) * fixed solidity todo tests * regression test * naming * fix tests coverage (#214) --------- Co-authored-by: Dmitry Redkin <tanatonaut@gmail.com> Co-authored-by: todesstille <87335281+todesstille@users.noreply.github.com> * Feature/token preallocation (#213) * allocation added * refactored * tests * environment proxy and tests * govpool preallocation * fixes * added allocator and payee roles * metadata * view functions * added auxiliary contracts deploy * dependand * tx.origin * unlock in multiplier * function annotations * fixes * fixes * Feature/token factory (#215) * predeploy token * handle invalid deploy * integrated with allocator * token allocator integration * Feature/gov tokens (#216) * burnable pausable * capped * tokens * removed old tests * fixes (#217) * revards 1/100 * .env.example * Feature/staking (#220) * base staking * getUserInfo * removed some data * refactor * coverage 100 * event on reclaim * view finction * fix active proposals * deploy staking * canMove * unsaved * events --------- Co-authored-by: Artem Chystiakov <47551140+Arvolear@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.