build!: update ic-cdk to v0.18.7
#21
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpahlavi
force-pushed
the
lpahlavi/XC-412-update-ic-cdk
branch
from
3ddd9de to
59aedd8
Compare
lpahlavi
changed the title
ic-cdk to v0.18.7ic-cdk to v0.18.7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(XC-502) Update the
ic-cdkversion tov0.18. This is a major upgrade of theic-cdkand as such is a breaking change forcanhttp.BREAKING: There are multiple breaking changes in this PR:
IcError,IcHttpRequestWithCyclesandhttp::CyclesCostEstimatorare removed.Client:Service<IcHttpRequestWithCycles>Service<ic_management_canister_types::HttpRequestArgs>CyclesAccounting:Convert<ic_cdk::api::management_canister::http_request::CanisterHttpRequestArgument>Filter<ic_management_canister_types::HttpRequestArgs>CyclesAccounting::newno longer takes anum_nodes_in_subnetargument.CyclesChargingPolicy::charge_cyclesnow takes aic_management_canister_types::HttpRequestArgsas argument.