Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: safe binding for msg_deadline #545

Merged
merged 2 commits into from
Jan 13, 2025
Merged

feat: safe binding for msg_deadline #545

merged 2 commits into from
Jan 13, 2025
+75 −2

Conversation

lwshang
Copy link
Contributor

@lwshang lwshang commented Jan 11, 2025 •
edited
Loading

Description

msg_deadline is a new system API as a part of the Best-Effort Responses feature.

It's specification can be found here.

How Has This Been Tested?

e2e-tests api.rs

Checklist:

  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@lwshang lwshang marked this pull request as ready for review January 13, 2025 14:06
@lwshang lwshang requested a review from a team as a code owner January 13, 2025 14:06
adamspofford-dfinity
adamspofford-dfinity reviewed Jan 13, 2025
View reviewed changes
ic-cdk/src/api.rs Outdated Show resolved Hide resolved
e2e-tests/src/bin/api.rs Outdated Show resolved Hide resolved
@lwshang lwshang merged commit 5fb07f5 into next Jan 13, 2025
11 checks passed
@lwshang lwshang deleted the lwshang/SDK-1929-msg_deadline branch January 13, 2025 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamspofford-dfinity adamspofford-dfinity adamspofford-dfinity approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lwshang @adamspofford-dfinity