feat(dre): Add forum post link to commands for proposal discussion (#830

)

rs/cli/src/commands/api_boundary_nodes/add.rs

@@ -39,6 +39,7 @@ impl ExecutableCommand for Add {
                     title: Some(format!("Add {} API boundary node(s)", self.nodes.len())),
                     summary: Some(format!("Add {} API boundary node(s)", self.nodes.len())),
                     motivation: self.motivation.clone(),
+                    forum_post_link: ctx.forum_post_link(),
                 },
             )
             .await?;

rs/cli/src/commands/api_boundary_nodes/remove.rs

@@ -31,6 +31,7 @@ impl ExecutableCommand for Remove {
                     title: Some(format!("Remove {} API boundary node(s)", self.nodes.len())),
                     summary: Some(format!("Remove {} API boundary node(s)", self.nodes.len())),
                     motivation: self.motivation.clone(),
+                    forum_post_link: ctx.forum_post_link(),
                 },
             )
             .await?;

rs/cli/src/commands/api_boundary_nodes/update.rs

@@ -38,6 +38,7 @@ impl ExecutableCommand for Update {
                     title: Some(format!("Update {} API boundary node(s) to {}", self.nodes.len(), &self.version)),
                     summary: Some(format!("Update {} API boundary node(s) to {}", self.nodes.len(), &self.version)),
                     motivation: self.motivation.clone(),
+                    forum_post_link: ctx.forum_post_link(),
                 },
             )
             .await?;

rs/cli/src/commands/heal.rs

@@ -12,7 +12,7 @@ impl ExecutableCommand for Heal {
 
     async fn execute(&self, ctx: crate::ctx::DreContext) -> anyhow::Result<()> {
         let runner = ctx.runner().await;
-        runner.network_heal().await
+        runner.network_heal(ctx.forum_post_link()).await
     }
 
     fn validate(&self, _cmd: &mut clap::Command) {}

rs/cli/src/commands/hostos/rollout.rs

@@ -21,7 +21,9 @@ impl ExecutableCommand for Rollout {
 
     async fn execute(&self, ctx: crate::ctx::DreContext) -> anyhow::Result<()> {
         let runner = ctx.runner().await;
-        runner.hostos_rollout(self.nodes.clone(), &self.version, None).await
+        runner
+            .hostos_rollout(self.nodes.clone(), &self.version, None, ctx.forum_post_link())
+            .await
     }
 
     fn validate(&self, _cmd: &mut clap::Command) {}

rs/cli/src/commands/hostos/rollout_from_node_group.rs

@@ -87,7 +87,9 @@ impl ExecutableCommand for RolloutFromNodeGroup {
             .hostos_rollout_nodes(update_group, &self.version, &self.only, &self.exclude)
             .await?
         {
-            return runner.hostos_rollout(nodes_to_update, &self.version, Some(summary)).await;
+            return runner
+                .hostos_rollout(nodes_to_update, &self.version, Some(summary), ctx.forum_post_link())
+                .await;
         }
 
         Ok(())

rs/cli/src/commands/mod.rs

@@ -111,6 +111,10 @@ The argument is mandatory for testnets, and is optional for mainnet and staging"
     /// Useful for when the nns is unreachable
     #[clap(long)]
     pub no_sync: bool,
+
+    /// Link to the related forum post, where proposal details can be discussed
+    #[clap(long, global = true, visible_aliases = &["forum-link", "forum"])]
+    pub forum_post_link: Option<String>,
 }
 
 macro_rules! impl_executable_command_for_enums {

rs/cli/src/commands/nodes/remove.rs

@@ -39,6 +39,7 @@ impl ExecutableCommand for Remove {
                 extra_nodes_filter: self.extra_nodes_filter.clone(),
                 exclude: Some(self.exclude.clone()),
                 motivation: self.motivation.clone().unwrap_or_default(),
+                forum_post_link: ctx.forum_post_link(),
             })
             .await
     }

rs/cli/src/commands/subnet/create.rs

@@ -66,6 +66,7 @@ impl ExecutableCommand for Create {
                     include: self.include.clone().into(),
                 },
                 motivation.to_string(),
+                ctx.forum_post_link(),
                 self.replica_version.clone(),
                 self.other_args.to_owned(),
                 self.help_other_args,

rs/cli/src/commands/subnet/deploy.rs

@@ -21,7 +21,7 @@ impl ExecutableCommand for Deploy {
 
     async fn execute(&self, ctx: crate::ctx::DreContext) -> anyhow::Result<()> {
         let runner = ctx.runner().await;
-        runner.deploy(&self.id, &self.version).await
+        runner.deploy(&self.id, &self.version, ctx.forum_post_link()).await
     }
 
     fn validate(&self, _cmd: &mut clap::Command) {}

rs/cli/src/commands/subnet/replace.rs

@@ -72,7 +72,7 @@ impl ExecutableCommand for Replace {
 
         let runner = ctx.runner().await;
 
-        runner.propose_subnet_change(subnet_change_response).await
+        runner.propose_subnet_change(subnet_change_response, ctx.forum_post_link()).await
     }
 
     fn validate(&self, cmd: &mut clap::Command) {

rs/cli/src/commands/subnet/rescue.rs

@@ -22,7 +22,7 @@ impl ExecutableCommand for Rescue {
     async fn execute(&self, ctx: crate::ctx::DreContext) -> anyhow::Result<()> {
         let runner = ctx.runner().await;
 
-        runner.subnet_rescue(&self.id, self.keep_nodes.clone()).await
+        runner.subnet_rescue(&self.id, self.keep_nodes.clone(), ctx.forum_post_link()).await
     }
 
     fn validate(&self, _cmd: &mut clap::Command) {}

rs/cli/src/commands/subnet/resize.rs

@@ -54,6 +54,7 @@ impl ExecutableCommand for Resize {
                     include: self.include.clone().into(),
                 },
                 self.motivation.clone(),
+                ctx.forum_post_link(),
                 &runner.health_of_nodes().await?,
             )
             .await

rs/cli/src/commands/update_authorized_subnets.rs

@@ -103,6 +103,7 @@ impl ExecutableCommand for UpdateAuthorizedSubnets {
                     title: Some("Update list of public subnets".to_string()),
                     summary: Some(summary),
                     motivation: None,
+                    forum_post_link: ctx.forum_post_link(),
                 },
             )
             .await?;

rs/cli/src/commands/update_unassigned_nodes.rs

@@ -41,7 +41,9 @@ impl ExecutableCommand for UpdateUnassignedNodes {
             }
         };
 
-        runner.update_unassigned_nodes(&PrincipalId::from_str(&nns_subnet_id)?).await
+        runner
+            .update_unassigned_nodes(&PrincipalId::from_str(&nns_subnet_id)?, ctx.forum_post_link())
+            .await
     }
 
     fn validate(&self, _cmd: &mut clap::Command) {}

rs/cli/src/commands/version/revise/guest_os.rs

@@ -25,7 +25,13 @@ impl ExecutableCommand for GuestOs {
     async fn execute(&self, ctx: crate::ctx::DreContext) -> anyhow::Result<()> {
         let runner = ctx.runner().await;
         runner
-            .do_revise_elected_replica_versions(&ic_management_types::Artifact::GuestOs, &self.version, &self.release_tag, self.force)
+            .do_revise_elected_replica_versions(
+                &ic_management_types::Artifact::GuestOs,
+                &self.version,
+                &self.release_tag,
+                self.force,
+                ctx.forum_post_link(),
+            )
             .await
     }
 

rs/cli/src/commands/version/revise/host_os.rs

@@ -25,7 +25,13 @@ impl ExecutableCommand for HostOs {
     async fn execute(&self, ctx: crate::ctx::DreContext) -> anyhow::Result<()> {
         let runner = ctx.runner().await;
         runner
-            .do_revise_elected_replica_versions(&ic_management_types::Artifact::HostOs, &self.version, &self.release_tag, self.force)
+            .do_revise_elected_replica_versions(
+                &ic_management_types::Artifact::HostOs,
+                &self.version,
+                &self.release_tag,
+                self.force,
+                ctx.forum_post_link(),
+            )
             .await
     }
 

rs/cli/src/ctx.rs

@@ -35,6 +35,7 @@ pub struct DreContext {
     verbose_runner: bool,
     skip_sync: bool,
     ic_admin_path: Option<String>,
+    forum_post_link: Option<String>,
 }
 
 impl DreContext {
@@ -83,6 +84,7 @@ impl DreContext {
             verbose_runner: args.verbose,
             skip_sync: args.no_sync,
             ic_admin_path,
+            forum_post_link: args.forum_post_link.clone(),
         })
     }
 
@@ -234,4 +236,8 @@ impl DreContext {
         *self.runner.borrow_mut() = Some(runner.clone());
         runner
     }
+
+    pub fn forum_post_link(&self) -> Option<String> {
+        self.forum_post_link.clone()
+    }
 }

rs/cli/src/ic_admin.rs

@@ -143,7 +143,19 @@ impl IcAdminWrapper {
                         .map(|s| {
                             vec![
                                 "--summary".to_string(),
-                                format!("{}{}", s, opts.motivation.map(|m| format!("\n\nMotivation: {m}")).unwrap_or_default(),),
+                                format!(
+                                    "{}{}",
+                                    s,
+                                    opts.motivation
+                                        .map(|m| format!(
+                                            "\n\nMotivation: {m}{}",
+                                            match opts.forum_post_link {
+                                                Some(link) => format!("\nForum post link: {}\n", link),
+                                                None => "".to_string(),
+                                            }
+                                        ))
+                                        .unwrap_or_default(),
+                                ),
                             ]
                         })
                         .unwrap_or_default(),
@@ -720,6 +732,7 @@ pub struct ProposeOptions {
     pub title: Option<String>,
     pub summary: Option<String>,
     pub motivation: Option<String>,
+    pub forum_post_link: Option<String>,
 }
 const DEFAULT_IC_ADMIN_VERSION: &str = "26d5f9d0bdca0a817c236134dc9c7317b32c69a5";
 

rs/cli/src/qualification/retire_blessed_versions.rs

@@ -49,6 +49,7 @@ impl Step for RetireBlessedVersions {
                         title: Some("Retire replica versions".to_string()),
                         summary: Some("Unelecting a version".to_string()),
                         motivation: Some("Unelecting a version".to_string()),
+                        forum_post_link: None,
                     },
                 )
                 .await

rs/cli/src/qualification/upgrade_subnets.rs

@@ -99,6 +99,7 @@ impl Step for UpgradeSubnets {
                                 title: Some(format!("Propose to upgrade subnet {} to {}", subnet.principal, &self.to_version)),
                                 summary: Some("Qualification testing".to_string()),
                                 motivation: Some("Qualification testing".to_string()),
+                                forum_post_link: None,
                             },
                         )
                         .await
@@ -140,6 +141,7 @@ impl Step for UpgradeSubnets {
                             title: Some("Upgrading unassigned nodes".to_string()),
                             summary: Some("Upgrading unassigned nodes".to_string()),
                             motivation: Some("Upgrading unassigned nodes".to_string()),
+                            forum_post_link: None,
                         },
                     )
                     .await