Skip to content

feat: add ckDOGE package#1468

Open
dantol29 wants to merge 1 commit intodfinity:mainfrom
dantol29:feat/ckdoge
Open

feat: add ckDOGE package#1468
dantol29 wants to merge 1 commit intodfinity:mainfrom
dantol29:feat/ckdoge

Conversation

@dantol29
Copy link

Motivation

add support for ckDOGE

Changes

new package - ckdoge

Tests

I modified tests from ckbtc package because ckdoge canister exposes almost identical api

Todos

Copy link
Member

@peterpeterparker peterpeterparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

While it's appreciated, as I mentioned in my response to your original issue #1466, this feature likely won't be implemented in these libraries right now. None of our dapps (this repo is maintained by the OISY and NNS teams) are currently, to my knowledge, working on integrating it. OISY will eventually add support for it, but it's unclear exactly how and when.

More broadly, we've always followed a battle-tested approach when shipping new features in ic-js: we develop them in our dapps first, to find and propose the most suitable API, uncover potential issues, and share tooling that we know works reliably in production frontend apps. This has always been our way of ensuring a certain level of quality for the community.

We'll keep the PR open (I'm tagging it as "requesting changes" to avoid an accidental merge) and revisit it when the topic is actively being developed. In the meantime, it should serve as a useful reference for anyone interested in exploring this area.

Hope that makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants