Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #208

Merged

Conversation

anchpop
Copy link
Collaborator

@anchpop anchpop commented Jan 24, 2024

Description

This PR is a followup to #207, and fixes #206. It updates many dependencies to their latest versions, including candid and everything that depends on the IC repo.

How Has This Been Tested?

I ran

cargo run --no-default-features -- sns make-proposal "016709e02f2466d9cfafc13fcc549cfb3d59f142c2996d2f18c94a3edbe93570" --proposal '(
    record {
        title = "Mint 41100 ICP to Foo Labs";
        url = "https://sns-examples.com/proposal/42";
        summary = "Mint 411 ICP to Foo Labs";
        action = opt variant {
            MintSnsTokens = record {

                to_principal = opt principal "ozcnp-xcxhg-inakz-sg3bi-nczm3-jhg6y-idt46-cdygl-ebztx-iq4ft-vae";

                to_subaccount = null;

                memo = null;

                amount_e8s = opt 4_110_000_000_000 : opt nat64;
            }
        }
    }
)' --canister-ids-file canister-ids.json > msg.json

Then

❯ cargo run -- send --yes msg.json --insecure-local-dev-mode
    Finished dev [unoptimized + debuginfo] target(s) in 0.61s
     Running `target/debug/quill send --yes msg.json --insecure-local-dev-mode`
Sending message with

  Call type:   update
  Sender:      2vxsx-fae
  Canister id: br5f7-7uaaa-aaaaa-qaaca-cai
  Method name: manage_neuron
  Arguments:   (
  record {
    subaccount = blob "\01\67\09\e0\2f\24\66\d9\cf\af\c1\3f\cc\54\9c\fb\3d\59\f1\42\c2\99\6d\2f\18\c9\4a\3e\db\e9\35\70";
    command = opt variant {
      MakeProposal = record {
        url = "https://sns-examples.com/proposal/42";
        title = "Mint 41100 ICP to Foo Labs";
        action = opt variant {
          MintSnsTokens = record {
            to_principal = opt principal "ozcnp-xcxhg-inakz-sg3bi-nczm3-jhg6y-idt46-cdygl-ebztx-iq4ft-vae";
            to_subaccount = null;
            memo = null;
            amount_e8s = opt (4_110_000_000_000 : nat64);
          }
        };
        summary = "Mint 411 ICP to Foo Labs";
      }
    };
  },
)

Which did not work before.

I didn't do any tests of anything that required build features to be enabled (e.g. ledger nano)

Updating dependencies required updating the rust version, which introduced new clippy lints, which then had to be fixed to get CI to pass (and should be fixed anyway :D ). So much of the changeset is from that.

@anchpop anchpop requested a review from a team as a code owner January 24, 2024 19:50
@anchpop anchpop changed the title @anchpop/update candid and did Update dependencies Jan 24, 2024
@anchpop anchpop force-pushed the @anchpop/update-candid-and-did branch from ab54532 to 219f00d Compare January 24, 2024 19:54
@anchpop anchpop force-pushed the @anchpop/update-candid-and-did branch from 219f00d to ed5dbaf Compare January 24, 2024 19:57
@adamspofford-dfinity adamspofford-dfinity merged commit e1f947c into dfinity:master Jan 29, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Quill candid files are out of date with new SNS/NNS versions
2 participants