Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Display nanosecond timestamps in NewSaleTicketResponse instances #247

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

aterga
Copy link
Contributor

@aterga aterga commented Dec 5, 2024

Description

This PR fixes the display_new_sale_ticket function by correctly treating nanosecond timestamps in NewSaleTicketResponse.ok.creation_time instances.

How Has This Been Tested?

Tested manually using sns-testing.

Checklist

  • I have made corresponding changes to the documentation in docs/cli-reference.

    • No, as this is a bug fix.
  • I have added corresponding integration tests.

    • No, as there are no SNS integrating tests in this repo. It does not follow from the SNS API that the creation_time field carries nanoseconds.

@aterga aterga requested a review from a team as a code owner December 5, 2024 20:25
@aterga aterga merged commit 7399550 into master Dec 5, 2024
33 checks passed
@adamspofford-dfinity adamspofford-dfinity deleted the arshavir/fix-display_new_sale_ticket branch December 6, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants