fix: aging_since should be formatted using format_timestamp_seconds, not format_duration_seconds. #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ormat_duration_seconds.
aterga
approved these changes
Jan 29, 2025
adamspofford-dfinity
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just something that I randomly noticed while using the tool. What I saw:
Since the IC did not exist 52 years ago, something was very apparently wrong.
This is a correct change, because the field
aging_since_timestamp_seconds(as the name indicates) holds a timestamp.(Note that 52 years + 7 months after the UNIX epoch is in 2022, which is a very reasonable "aging since" value.)
Description
The title already says it all.
Closes NNS1-3307.
How Has This Been Tested?
I ran
cargo test(and it worked).I also built the tool, and ran it like I did before, and reported age of the neuron makes more sense now. (BTW, I struggled to get the
--hsmflag to work. Would be nice if the README had more guidance on this, but I'm not sure what it should say; I just hacked until it worked.)Checklist
I have made corresponding changes to the documentation in docs/cli-reference. No need, because the way that users operate the tool is the unchanged.
I have added corresponding integration tests. This does not add any new functionality; just fixes a tiny formatting bug.