Skip to content

feat: generated go sdk#18

Merged
ncornwell merged 4 commits intomainfrom
feat/sdk-generated
Mar 10, 2026
Merged

feat: generated go sdk#18
ncornwell merged 4 commits intomainfrom
feat/sdk-generated

Conversation

@ncornwell
Copy link
Collaborator

No description provided.

@ncornwell ncornwell force-pushed the feat/sdk-generated branch 3 times, most recently from e5b068f to e22abc7 Compare March 9, 2026 03:44
@pierre-dfns
Copy link
Contributor

pierre-dfns commented Mar 9, 2026

the cmd/example has to be modified as well (cmd/config.go for example)

@ncornwell ncornwell force-pushed the feat/sdk-generated branch from e22abc7 to e53481f Compare March 9, 2026 13:43
@pierre-dfns
Copy link
Contributor

pierre-dfns commented Mar 9, 2026

  • No snake_case for parameters (Go uses CamelCase).
  • Acronyms should be uppercase: Http → HTTP.
  • types/types.go: in Go, types usually live in the package they belong to (for example CreateWalletRequest should be in the wallets package). (not sure if it's hard to do so)
  • body interface{}: it would be better if this were typed. Usually in Go we have XXXRequest XXXResponse
  • go.sum was deleted (!!).

@ncornwell ncornwell force-pushed the feat/sdk-generated branch from e53481f to 73a1c5e Compare March 9, 2026 14:10
@ncornwell ncornwell force-pushed the feat/sdk-generated branch from 73a1c5e to 38a575a Compare March 9, 2026 14:29
@codecov
Copy link

codecov bot commented Mar 9, 2026

Codecov Report

❌ Patch coverage is 97.24138% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.24%. Comparing base (b2aa1ed) to head (9501af3).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
internal/client/client.go 97.67% 1 Missing and 1 partial ⚠️
signer/key.go 96.61% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #18      +/-   ##
==========================================
+ Coverage   90.95%   97.24%   +6.28%     
==========================================
  Files           7        2       -5     
  Lines         365      145     -220     
==========================================
- Hits          332      141     -191     
+ Misses         18        2      -16     
+ Partials       15        2      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pierre-dfns pierre-dfns force-pushed the feat/sdk-generated branch 2 times, most recently from 855a261 to 57a6272 Compare March 10, 2026 09:28
@ncornwell ncornwell merged commit 21fc864 into main Mar 10, 2026
8 checks passed
@ncornwell ncornwell deleted the feat/sdk-generated branch March 10, 2026 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants