Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FHI-aims to users of s-dftd3 library list #131

Merged
merged 2 commits into from
Dec 20, 2024

Conversation

jamesagreen
Copy link
Contributor

I recently implemented the simple-dftd3 library into FHI-aims (https://fhi-aims.org/), as of version 240920. Therefore I updated the "Users of this library" list in the docs to reflect this.

Signed-off by: James Green <green@ms1p.org>
Copy link
Member

@awvwgk awvwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, great to see D3 in FHI-aims.

Some minor suggestions for the reference, otherwise looks good to me.

date = {2009},
journal = {Computer Physics Communications},
title = {Ab initio molecular simulations with numeric atom-centered orbitals},
doi = {https://doi.org/10.1016/j.cpc.2009.06.022},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
doi = {https://doi.org/10.1016/j.cpc.2009.06.022},
doi = {10.1016/j.cpc.2009.06.022},

doi = {https://doi.org/10.1016/j.cpc.2009.06.022},
number = {11},
pages = {2175-2196},
url = {https://www.sciencedirect.com/science/article/pii/S0010465509002033},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
url = {https://www.sciencedirect.com/science/article/pii/S0010465509002033},
url = {https://doi.org/10.1016/j.cpc.2009.06.022},

Signed-off by: James Green <green@ms1p.org>
@jamesagreen
Copy link
Contributor Author

Sure thing, I just updated the reference!

@awvwgk awvwgk merged commit f183094 into dftd3:main Dec 20, 2024
19 of 20 checks passed
@jamesagreen jamesagreen deleted the fhi-aims-doc branch December 20, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants