Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of Actinides. #48

Merged
merged 10 commits into from
Nov 21, 2023
Merged

Implementation of Actinides. #48

merged 10 commits into from
Nov 21, 2023

Conversation

lukaswittmann
Copy link
Contributor

Description

Added actinides support to the Fortran version, following the Torch autodiff DFT-D3 implementation by FreeSoulIG.

Changes Made

  • Added support for actinides in the Fortran version, based on the changes made in commit b943853
  • Implemented necessary new vdw and c6ab parameters
  • Added new tests for the actinides

Crosschecked and validated results from both implementations to ensure accuracy. The test suite successfully completed without any errors.

@awvwgk
Copy link
Member

awvwgk commented Nov 7, 2023

Thanks for sharing. Looks good to me.

Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Attention: 20 lines in your changes are missing coverage. Please review.

Comparison is base (cdd0a85) 50.15% compared to head (ac3c6d3) 48.63%.

Files Patch % Lines
test/unit/test_model.f90 33.33% 0 Missing and 8 partials ⚠️
test/unit/test_dftd3.f90 45.45% 0 Missing and 6 partials ⚠️
test/unit/test_ncoord.f90 40.00% 0 Missing and 6 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #48      +/-   ##
==========================================
- Coverage   50.15%   48.63%   -1.53%     
==========================================
  Files          34       34              
  Lines        3776     3707      -69     
  Branches     1601     1518      -83     
==========================================
- Hits         1894     1803      -91     
- Misses       1206     1207       +1     
- Partials      676      697      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lukaswittmann
Copy link
Contributor Author

lukaswittmann commented Nov 8, 2023

Potentially fixed the weird build check error of build (ubuntu-20.04, meson, debug, intel, 2021.2.0) by shortening the lines in the reference file.

@lukaswittmann
Copy link
Contributor Author

lukaswittmann commented Nov 8, 2023

The build (ubuntu-20.04, meson, debug, intel, 2021.2.0) still fails, even after lines were truncated.

I am clueless as to why this is happening. Does anyone else have any insights into the possible reasons for this occurrence?

@awvwgk
Copy link
Member

awvwgk commented Nov 20, 2023

Can't say why the Intel build is failing, there have been issues with the array constructors and number of continuation lines before. It would be mandatory to fix those issues before merging this patch.

@lukaswittmann
Copy link
Contributor Author

Fixed the issue @awvwgk.
The construction of the array was split up into blocks of 2000 parameters; the build finished successfully.

Copy link
Member

@awvwgk awvwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now

@awvwgk awvwgk merged commit eb7998d into dftd3:main Nov 21, 2023
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants