Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workarounds for Cray compilers #77

Merged
merged 4 commits into from
Aug 12, 2024
Merged

Workarounds for Cray compilers #77

merged 4 commits into from
Aug 12, 2024

Conversation

fedepedron
Copy link
Contributor

Implements the workarounds for Cray compilers mentioned in #76.

Closes #76.

fedepedron and others added 2 commits August 12, 2024 07:56
Signed-off-by: Federico Pedron <fedekbe@gmail.com>
Copy link

codecov bot commented Aug 12, 2024

Codecov Report

Attention: Patch coverage is 8.33333% with 11 lines in your changes missing coverage. Please review.

Project coverage is 50.24%. Comparing base (3a50cbd) to head (f40f6be).
Report is 13 commits behind head on main.

Files Patch % Lines
src/dftd3/output.f90 8.33% 10 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #77      +/-   ##
==========================================
+ Coverage   48.63%   50.24%   +1.60%     
==========================================
  Files          34       24      -10     
  Lines        3707     2448    -1259     
  Branches     1518      987     -531     
==========================================
- Hits         1803     1230     -573     
+ Misses       1207      877     -330     
+ Partials      697      341     -356     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@awvwgk awvwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sharing. Looks good to me.

@awvwgk awvwgk changed the title Workarounds for Cray compilers. Workarounds for Cray compilers Aug 12, 2024
@awvwgk awvwgk merged commit f147b26 into dftd3:main Aug 12, 2024
33 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Workaround for Cray Compilers
2 participants