Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not override grad_output at the end of arguments parsing #85

Merged
merged 1 commit into from
Sep 22, 2024

Conversation

foxtran
Copy link
Contributor

@foxtran foxtran commented Sep 22, 2024

Fixes #84

Now, it works as expected:

$ ./s-dftd3 CO.xyz --bj tpss --grad hdfgd
<...>
Virial:
--------------------------------------------------
      component           x          y          z
--------------------------------------------------
          x       0.000E+00  0.000E+00  0.000E+00
          y       0.000E+00  0.000E+00  0.000E+00
          z       0.000E+00  0.000E+00  1.711E-06
--------------------------------------------------

[Info] Dispersion energy written to .EDISP
[Info] Dispersion results written to 'hdfgd'

Copy link
Member

@awvwgk awvwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Thanks for sharing.

Copy link

codecov bot commented Sep 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 50.24%. Comparing base (3a50cbd) to head (29771d9).
Report is 19 commits behind head on main.

Files with missing lines Patch % Lines
app/cli.f90 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #85      +/-   ##
==========================================
+ Coverage   48.63%   50.24%   +1.60%     
==========================================
  Files          34       24      -10     
  Lines        3707     2448    -1259     
  Branches     1518      987     -531     
==========================================
- Hits         1803     1230     -573     
+ Misses       1207      877     -330     
+ Partials      697      341     -356     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@awvwgk awvwgk merged commit 1f4e459 into dftd3:main Sep 22, 2024
42 of 43 checks passed
@foxtran foxtran deleted the patch-1 branch September 23, 2024 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--grad file.out creates dftd3.txt instead of file.out
2 participants