Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

With --json, --grad should not accept extra argument #98

Closed
wants to merge 1 commit into from

Conversation

foxtran
Copy link
Contributor

@foxtran foxtran commented Sep 23, 2024

Fixes #97

Copy link

codecov bot commented Sep 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 50.22%. Comparing base (3a50cbd) to head (e68f93f).
Report is 20 commits behind head on main.

Files with missing lines Patch % Lines
app/cli.f90 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #98      +/-   ##
==========================================
+ Coverage   48.63%   50.22%   +1.58%     
==========================================
  Files          34       24      -10     
  Lines        3707     2449    -1258     
  Branches     1518      988     -530     
==========================================
- Hits         1803     1230     -573     
+ Misses       1207      878     -329     
+ Partials      697      341     -356     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@awvwgk awvwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is an intuitive feature to implement as the behavior of --grad would depend on whether it comes before or after the --json argument.

With this PR

s-dftd3 test.xyz --json --grad test.txt

would fail because of the extra argument but

s-dftd3 test.xyz --grad test.txt --json

would be fine.

@foxtran foxtran closed this Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Top-level README: Running simple-dftd3 from the CLI Instructions Fail
2 participants