Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/fix raft bug #11

Closed
wants to merge 4 commits into from
Closed

Feat/fix raft bug #11

wants to merge 4 commits into from

Conversation

bubbajoe
Copy link
Contributor

@bubbajoe bubbajoe commented Jun 7, 2024

No description provided.

ps.logger.Debug("No namespace found for request",
zap.String("protocol", r.Proto),
zap.String("host", r.Host),
zap.String("path", r.URL.Path),
zap.Bool("secure", r.TLS != nil),
zap.String("remote_addr", r.RemoteAddr),
zap.String("remote_addr", trustedIp),

Check failure

Code scanning / CodeQL

Clear-text logging of sensitive information High

Sensitive data returned by HTTP request headers
flows to a logging call.
Copy link

codecov bot commented Jun 7, 2024

Codecov Report

Attention: Patch coverage is 11.93182% with 155 lines in your changes missing coverage. Please review.

Project coverage is 37.79%. Comparing base (d577368) to head (7be75b7).

Files Patch % Lines
internal/proxy/proxy_state.go 3.63% 52 Missing and 1 partial ⚠️
internal/admin/admin_fsm.go 0.00% 44 Missing ⚠️
internal/admin/admin_routes.go 0.00% 21 Missing ⚠️
internal/proxy/change_log.go 13.33% 11 Missing and 2 partials ⚠️
pkg/util/http.go 0.00% 8 Missing ⚠️
pkg/spec/change_log.go 0.00% 7 Missing ⚠️
pkg/spec/response_writer_tracker.go 0.00% 5 Missing ⚠️
internal/proxy/proxy_handler.go 84.21% 1 Missing and 2 partials ⚠️
pkg/dgclient/common.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #11      +/-   ##
==========================================
- Coverage   37.88%   37.79%   -0.10%     
==========================================
  Files         116      116              
  Lines        9533     9580      +47     
==========================================
+ Hits         3612     3621       +9     
- Misses       5512     5542      +30     
- Partials      409      417       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bubbajoe bubbajoe closed this Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant