-
Notifications
You must be signed in to change notification settings - Fork 2
bronkhorst_test #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This is an example of a dummy function (has the same functionality as the "based_function")
This is the test function of the dummy function. It is the first version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work. Please address the comments below. After that's done, we can proceed in the following steps:
- merge this PR so there's some code in the repo
- design
pyproject.toml
so that it's a package - by that point, Implement
DriverInterface
class tomato#86 should be merged, and then we can try to run your driver via tomato by implementing aDriverInterface
class
Those are the updated version of the codes taking the remarks into considerations.
test related to the dummy function 2
Updated versions. Where I took all of the remarks into account. |
Here is the pyroject.toml related to our first package !
We are working only on .py files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks a little better.
Please remove either based_func2.py
or based_function.py
and the same for the dummy_function
and dummy_test
files. This PR should have only 4 files:
based_function.py
dummy_function.py
dummy_test.py
pyproject.toml
Not needed anymore since we got a pyproject
we only keep the latest test
We keep the latest function
corrected the requested elements !
updated version of the previous code.