Skip to content

bronkhorst_test #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Aug 21, 2024
Merged

bronkhorst_test #1

merged 17 commits into from
Aug 21, 2024

Conversation

AlexN7-Shepard
Copy link
Collaborator

updated version of the previous code.

  • Used the polar bronkhorst library
  • Has to be tested
  • opens the valve automatically when you run the code
  • print all the available devices connected
  • gives all the properties of the current devices
  • unfortunately we will have to search manually the min and max of the flow controllers
  • Close the valves
  • The units are stored in a xarray dataset alongside with the numerical values obtained during the duration of the experiments

This is an example of a dummy function (has the same functionality as the "based_function")
This is the test function of the dummy function.
It is the first version.
Copy link
Contributor

@PeterKraus PeterKraus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work. Please address the comments below. After that's done, we can proceed in the following steps:

  1. merge this PR so there's some code in the repo
  2. design pyproject.toml so that it's a package
  3. by that point, Implement DriverInterface class tomato#86 should be merged, and then we can try to run your driver via tomato by implementing a DriverInterface class

Those are the updated version of the codes taking the remarks into considerations.
test related to the dummy function 2
@AlexN7-Shepard
Copy link
Collaborator Author

updated version of the previous code.

  • Used the polar bronkhorst library
  • Has to be tested
  • opens the valve automatically when you run the code
  • print all the available devices connected
  • gives all the properties of the current devices
  • unfortunately we will have to search manually the min and max of the flow controllers
  • Close the valves
  • The units are stored in a xarray dataset alongside with the numerical values obtained during the duration of the experiments

Updated versions. Where I took all of the remarks into account.
-> It still needs to be tested when the lab and devices will be available.

Here is the pyroject.toml related to our first package !
@AlexN7-Shepard AlexN7-Shepard changed the title Test n°2 : Before making the package bronkhorst_test Jul 29, 2024
Copy link
Contributor

@PeterKraus PeterKraus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks a little better.

Please remove either based_func2.py or based_function.py and the same for the dummy_function and dummy_test files. This PR should have only 4 files:

  • based_function.py
  • dummy_function.py
  • dummy_test.py
  • pyproject.toml

AlexN7-Shepard and others added 7 commits August 20, 2024 19:24
Not needed anymore since we got a pyproject
we only keep the latest test
We keep the latest function
corrected the requested elements !
@PeterKraus PeterKraus merged commit 8c31ded into dgbowl:master Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants