Skip to content
This repository has been archived by the owner on May 21, 2022. It is now read-only.

Support array of strings and single string for aud value #355

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dklesev
Copy link

@dklesev dklesev commented Aug 28, 2019

Fix #348

@simonbrynych
Copy link

@dgrijalva don't you mind to merge one of fixes for audience as a []string, or string (as RFC says). This one looks like the best one to me.

@leucos
Copy link

leucos commented Nov 21, 2019

@dgrijalva do you plan to merge this PR ?

@enj
Copy link

enj commented Nov 25, 2019

Using interface{} here is the wrong approach. A custom type Audience []string with the appropriate unmarshall implementation will give you type safety and avoid panics.

Any attempt to fix this will likely be backwards incompatible from a Go perspective.

@dgrijalva
Copy link
Owner

This is a backward incompatible change. Please see the 4.0.0-preview1 release and see if that resolves your issue.

@zbindenren zbindenren mentioned this pull request Mar 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ParseWithClaims: getting json error when processing JWT that has multiple values for audience
5 participants