Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Station/popup #361

Merged
merged 16 commits into from
Oct 21, 2024
Merged

Station/popup #361

merged 16 commits into from
Oct 21, 2024

Conversation

the-matrixneo
Copy link
Contributor

318 issue closed

Hello !!! @dhairyagothi sir , I have successfully added the load on website pop up . I hope you will like it. i have added two files pop.css foe styling and pop.js under component and updated index.html. The load on website pop up will grab attention of new users Please merge a PR and if you can increase my level that would be highly appreciable.

Related Issue

load on website pop up added.

Description of Changes

New feature load on website popup added with the cross sign and a signup box.

Type of Pull Request

  • Bug Fix
  • New Feature
  • Performance Improvement
  • Documentation Update
  • Code Refactoring
  • Security Enhancement
  • Other (Specify): _______________

(Please check relevant boxes by entering an "X" inside them)

Checklist for Contributor

use'X' in [ ] to check it .

  • I have reviewed my code before submission.
  • I have read and followed the project's Contribution Guidelines.
  • I have tested the code thoroughly.
  • I have attached related issue numbers, screenshots, or videos (if applicable).
  • I have added comments to my code where necessary for clarity.
  • I have checked the existing code base and my changes do not introduce any breaking changes.
  • My PR addresses only one issue; I have created separate PRs for other issues.
  • I have ensured that the PR does not include unrelated files.
  • I am mindful of the project's coding standards and best practices.

Thank you
Dakshata
Gssoc'24 Extnd , Hacktoberfest

@vercel Vercel
Copy link

vercel bot commented Oct 21, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
station-guide ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 21, 2024 7:49pm
station-guide-backend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 21, 2024 7:49pm

@github-actions GitHub Actions
Copy link
Contributor

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@dhairyagothi dhairyagothi added enhancement New feature or request level 3 45 points issue gssoc-ext GSSOX'24 Extended hacktoberfest-accepted Hacktoberfest labels Oct 21, 2024
@dhairyagothi
Copy link
Owner

Thanks for contributing @daky2024

@dhairyagothi dhairyagothi merged commit 5df40e8 into dhairyagothi:main Oct 21, 2024
4 checks passed
@github-actions GitHub Actions
Copy link
Contributor

🎉 Your pull request has been successfully merged! 🎉 Thank you for your valuable contribution to Station Guide. Your efforts are greatly appreciated. Feel free to reach out if you have any more contributions or if there's anything else we can assist you with. Keep up the fantastic work! 🚀

@the-matrixneo
Copy link
Contributor Author

My pleasure @dhairyagothi sir.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhairyagothi dhairyagothi dhairyagothi approved these changes

Assignees

@the-matrixneo the-matrixneo

Labels
enhancement New feature or request gssoc-ext GSSOX'24 Extended hacktoberfest-accepted Hacktoberfest level 3 45 points issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@the-matrixneo @dhairyagothi