Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update index.html for issue in cursor follower #543

Closed
wants to merge 1 commit into from

Conversation

AaryaShrivaastava
Copy link

@AaryaShrivaastava AaryaShrivaastava commented Nov 12, 2024

Pull Request Template for GSoC 2024

Related Issue #474

[Please list any related issue numbers that this pull request resolves. If none, state "None"]

closes:

Description of Changes

This PR fixes an issue where the custom cursor follower element would misalign with the user's cursor when scrolling. The update adds the scroll offset to the coords.y position, ensuring that the cursor follower remains aligned with the mouse cursor even after scrolling.

Type of Pull Request

  • Bug Fix
  • New Feature
  • Performance Improvement
  • Documentation Update
  • Code Refactoring
  • Security Enhancement
  • Other (Specify): _______________

Screenshots / Demo (if applicable)

[Include any screenshots, GIFs, or videos that demonstrate the change or feature, if available.]

Checklist for Contributor

use'X' in [ ] to check it .

  • I have reviewed my code before submission.
  • I have read and followed the project's Contribution Guidelines.
  • I have tested the code thoroughly.
  • I have attached related issue numbers, screenshots, or videos (if applicable).
  • I have added comments to my code where necessary for clarity.
  • I have checked the existing code base and my changes do not introduce any breaking changes.
  • My PR addresses only one issue; I have created separate PRs for other issues.
  • I have ensured that the PR does not include unrelated files.
  • I am mindful of the project's coding standards and best practices.

Additional Information

This fix modifies the mousemove event handler to account for the page's vertical scroll offset, preventing alignment issues between the custom cursor follower and the mouse position after scrolling. This solution minimally impacts the original code structure.

The issue that I was facing and that I have tried to fix in this PR :

Station.Saarthi.-.Google.Chrome.2024-11-12.18-40-31.mp4

Contribution Guidelines Reminder

Thank you for contributing to our project! Please ensure you follow the guidelines below:

Contribution Levels

  1. Task Categories:

    • Basic Tasks: Primarily focused on small changes like minor bug fixes, documentation improvements, and unit testing. Labeled as Easy.
    • Intermediate Tasks: Moderate-level tasks that involve enhancing existing features, code refactoring, or performance improvements. Labeled as Medium.
    • Advanced Tasks: Complex tasks like building new features, significant refactoring, or critical bug fixes. Labeled as Hard.
  2. Acknowledging Effort:

    • Exceptional contributions will be recognized with a higher contribution level if substantial effort and innovation are demonstrated.

Review Process

  • PRs will be reviewed by the maintainers, and feedback will be provided. Contributors should address feedback promptly and resubmit the PR if necessary.

  • Contributors are encouraged to participate in the review process of other PRs for community growth.

We appreciate your time and effort in improving this project and look forward to your valuable contributions!

Copy link

vercel bot commented Nov 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
station-guide ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 12, 2024 1:25pm
station-guide-backend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 12, 2024 1:25pm

Copy link
Contributor

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants