chore: lint

dev/generate-coverage-report.ts

@@ -14,22 +14,21 @@ try {
     // ignore
 }
 
-const coverage = Deno.run({
-    cmd: ["deno", "coverage", "--unstable", SourceDir, "--lcov"],
+const coverage = new Deno.Command(Deno.execPath(), {
+    args: ["coverage", "--unstable", SourceDir, "--lcov"],
     stdout: "piped",
 });
-const output = await coverage.output();
-const coverageStatus = await coverage.status();
-if (coverageStatus.success && coverageStatus.code === 0) {
+const {stdout, success, code} = await coverage.output();
+if (success && code.code === 0) {
     const tmpFile = await Deno.makeTempFile({
         suffix: ".lcov",
     });
-    await Deno.writeFileSync(tmpFile, output);
+    await Deno.writeFileSync(tmpFile, stdout);
     console.log(`Written ${tmpFile}`);
-    const htmlStatus = await Deno.run({
-        cmd: ["genhtml", "-o", OutputDir, tmpFile],
-    }).status();
-    if (htmlStatus.success && htmlStatus.code === 0) {
+    const {success, code} = (await new Deno.Command("genhtml", {
+        args: ["-o", OutputDir, tmpFile],
+    }).output());
+    if (success && code === 0) {
         await Deno.remove(tmpFile);
         console.log(`Generated ${OutputDir}`);
         Deno.exit(0);

dev/intellij-deno.ts

@@ -1,6 +1,6 @@
 // This script is a workaround to allow using IntelliJ Run Configurations to execute "deno task" commands.
 // It is required because IntelliJ does not allow the "File" argument to be empty.
-const p = Deno.run({
-    cmd: ["deno", ...Deno.args],
+const p = new Deno.Command(Deno.execPath(), {
+    args: Deno.args,
 });
-await p.status();
+await p.spawn().status;

dev/internal/util.ts

@@ -10,10 +10,10 @@ export function call(
     cwd?: string,
     ...cmd: (string | undefined)[]
 ): ProcessLike {
-    let p: Deno.Process;
+    let p: Deno.ChildProcess;
     return {
         close() {
-            p && p.close();
+            p && p.kill();
         },
         // deno-lint-ignore require-await
         async run() {
@@ -26,29 +26,29 @@ export function callAndWait(
     cwd?: string,
     ...cmd: (string | undefined)[]
 ): ProcessLike {
-    let p: Deno.Process;
+    let p: Deno.ChildProcess;
     return {
         close() {
-            p && p.close();
+            p && p.kill();
         },
         async run() {
             p = process(cwd, ...cmd)();
-            await p.status();
+            await p.status;
         },
     };
 }
 
 function process(
     cwd?: string,
     ...cmd: (string | undefined)[]
-): () => Deno.Process {
+): () => Deno.ChildProcess {
     return () => {
         const actualCmd = cmd.filter((c) => Boolean(c)) as string[];
         try {
-            return Deno.run({
+            return new Deno.Command(actualCmd[0], {
                 ...cwd ? { cwd: path.resolve(Deno.cwd(), cwd) } : {},
-                cmd: actualCmd,
-            });
+                args: actualCmd.slice(1),
+            }).spawn();
         } catch (e) {
             console.error(`Could not execute ${actualCmd.join(" ")}`);
             throw e;

dev/write-build-info.ts

@@ -2,16 +2,16 @@ const PATH = "out/server.js";
 const SEARCH_STRING = `globalThis["BUILD_INFO"]`;
 
 async function execute(cmd: string[], fallback?: string): Promise<string | undefined> {
-    const p = Deno.run({
-        cmd,
+    const p = new Deno.Command(cmd[0], {
+        args: cmd.slice(1),
         stdout: "piped",
         stderr: "piped",
     });
-    const status = await p.status();
-    if (!status.success) {
+    const { success, stdout } = await p.output();
+    if (!success) {
         return fallback;
     }
-    return new TextDecoder().decode(await p.output()).trim();
+    return new TextDecoder().decode(stdout).trim();
 }
 
 const tag = await execute(["git", "describe", "--tags"]);

src/controllers/recipe.controller.ts

@@ -98,7 +98,8 @@ export class RecipeController {
         return renderTemplate(RecipeEditTemplate({ recipe }));
     }
 
-    async postEdit(id: number, data: Recipe, thumbnail: File | undefined, shouldDeleteThumbnail: boolean) {
+    // FIXME: use _data
+    async postEdit(id: number, _data: Recipe, thumbnail: File | undefined, shouldDeleteThumbnail: boolean) {
         const recipe = this.recipeService.find(
             id,
             true,

src/data/pagination.ts

@@ -110,7 +110,6 @@ export class PaginationBuilder<T> {
     }
 }
 
-// deno-lint-ignore no-undef
 export class Pagination<T> implements Iterable<T> {
     // noinspection JSUnusedGlobalSymbols
     public constructor(

src/data/parse/schema-parser.ts

@@ -10,7 +10,6 @@ export interface ParseHtmlToSchema {
     findFirstRecipe(): SchemaRecipe | null;
 }
 
-// deno-lint-ignore no-undef
 export class SchemaParser implements ParseHtmlToSchema {
     constructor(private readonly html: string) {
         this.html = html;

tests/data/parse/import/import-recipe.test.ts

@@ -5,7 +5,6 @@ import { importRecipes } from "../../../../src/data/parse/import/import-recipe.t
 import { ParseHtmlToSchema } from "../../../../src/data/parse/schema-parser.ts";
 import { FetchFn } from "../../../../src/data/util/fetch.ts";
 import { withTemp } from "../../../_internal/with-temp.function.ts";
-import TestContext = Deno.TestContext;
 
 Deno.test("importRecipes", async (t) => {
     let fetchCalls: { url: string; userAgent: string }[] = [];
@@ -42,7 +41,7 @@ Deno.test("importRecipes", async (t) => {
         }
     };
 
-    async function simpleTest(t: TestContext, given: unknown, then: unknown, schemaField: string, recipeField: string): Promise<void> {
+    async function simpleTest(t: Deno.TestContext, given: unknown, then: unknown, schemaField: string, recipeField: string): Promise<void> {
         beforeEach();
         await t.step(
             `Given ${JSON.stringify(given)} Then Recipe#${recipeField}=${JSON.stringify(then)}`,