Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: various issues related to the new toolbar #1522

Merged
merged 8 commits into from
Jun 27, 2023

Conversation

HendrikThePendric
Copy link
Contributor

@HendrikThePendric HendrikThePendric commented Jun 27, 2023

Implements DHIS2-15167

Relates to:


Description

The majority of the issues which were identified during today's KFMT session could be fixed here in @dhis2/analytics. Below is a summary of the subtasks which have been addressed in this PR:

  • DHIS2-15487 Decrease menu item font-size and height and ensure all menus are consistent
  • DHIS2-15488 Prevent text selection by adding user-select: none
  • DHIS2-15490 Ensure :active highlight does not appear on disabled menu dropdown buttons (FF)
  • DHIS2-15494 Toolbar menu items should have the grey "active" background when their dropdown menu is open
  • DHIS2-15495 Remove transition effect from menu button change background on hover instantly
  • DHIS2-15496 Blur dropdown button when closing dropdown menu using ESC
  • DHIS2-15497 Ensure plain data source menu styles are consistent

@HendrikThePendric HendrikThePendric changed the title DHIS2-15167-toolbar-UI-update-kfmt-issues fix: address toolbar issues found during KFMT Jun 27, 2023
@HendrikThePendric HendrikThePendric marked this pull request as ready for review June 27, 2023 12:45
@HendrikThePendric HendrikThePendric changed the title fix: address toolbar issues found during KFMT fix: various issues related to the new toolbar Jun 27, 2023
@HendrikThePendric HendrikThePendric merged commit d4a96e9 into master Jun 27, 2023
@HendrikThePendric HendrikThePendric deleted the DHIS2-15167-toolbar-UI-update-kfmt-issues branch June 27, 2023 13:14
dhis2-bot added a commit that referenced this pull request Jun 27, 2023
## [26.0.6](v26.0.5...v26.0.6) (2023-06-27)

### Bug Fixes

* various issues related to the new toolbar ([#1522](#1522)) ([d4a96e9](d4a96e9))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 26.0.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants