feat: migrate snapshot files too [LIBS-681] #878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kabaros
approved these changes
Oct 8, 2024
amcgee
approved these changes
Oct 8, 2024
|
🎉 This PR is included in version 12.0.0-alpha.16 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LIBS-681
Tested out in the Dashboard app, and the snapshots are indeed use for comparison -- the platform changes seem to have removed white space in some snaps as seen in the second screenshot below, for example.
One potential shortcoming of the script I noticed, however, is that it doesn't update file paths for things like mocked jest modules, resulting in errors like:
FAIL src/components/Item/VisualizationItem/__tests__/Item.spec.jsx ● Test suite failed to run Cannot find module '../../ItemHeader/DeleteItemButton.js' from 'src/components/Item/VisualizationItem/__tests__/Item.spec.jsx'Screenshots