Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [TECH-1644] flaky custom program stage working list tests #3420

Merged
merged 2 commits into from
Sep 27, 2023

Conversation

simonadomnisoru
Copy link
Contributor

@simonadomnisoru simonadomnisoru commented Sep 26, 2023

TECH-1644

Tech summary
Fix the flaky custom program stage working list tests by cleaning the DB

Copy link
Contributor

@eirikhaugstulen eirikhaugstulen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Contributor

@superskip superskip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You only do cleanup at the beginning of a test which is not among the flaky ones. I don't intuitively see how that could work... 😅

@simonadomnisoru simonadomnisoru merged commit ebe67c2 into master Sep 27, 2023
56 of 60 checks passed
@simonadomnisoru simonadomnisoru deleted the TECH-1644 branch September 27, 2023 08:49
@simonadomnisoru
Copy link
Contributor Author

You only do cleanup at the beginning of a test which is not among the flaky ones. I don't intuitively see how that could work... 😅

@superskip, the clean-up was applied to 5 scenarios:
The user can save a program stage working list, based on a TEI working list configuration by adding a new step

and to the other 4 by adding cleanUpIfApplicable in their initial step
The user creates, updates and deletes a Program stage custom working list
The Program stage custom working can be shared
The user can delete a Program stage working list right immediately after creating it.
The Program stage working list configuration is kept when changing the org unit

Thanks!

@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 100.40.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants