Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [TECH-1654] upgrade cypress to v12 #3429

Merged
merged 29 commits into from
Oct 26, 2023

Conversation

eirikhaugstulen
Copy link
Contributor

@eirikhaugstulen eirikhaugstulen commented Oct 2, 2023

Ran into some performance issues, so decided trying to update to v12.
There were however some breaking changes, and because of this, VCS got really hard to track. Therefore, here are the main headers:

  • All of our e2e tests are now moved from cypress/integration/** => cypress/e2e/**
  • Cucumber was deprecated by the previous maintainer, so I switched to the @badeball/cypress-cucumber-preprocessor package. (same code, just updated)
  • And is deprecated by cucumber, but for now we import { defineStep as And } and it will work the same way
  • We now cache both network calls and user sessions, which should greatly improve performance (at least it does locally)
  • Cypress is now a lot more strict on duplicate test step names, so I've deleted a lot of tests that were both in sharedSteps and the index-files.

@github-actions
Copy link

github-actions bot commented Oct 2, 2023

@eirikhaugstulen eirikhaugstulen changed the title chore: [TECH] upgrade cypress to v12 chore: [TECH-1654] upgrade cypress to v12 Oct 3, 2023
@eirikhaugstulen eirikhaugstulen marked this pull request as ready for review October 20, 2023 22:32
@eirikhaugstulen eirikhaugstulen requested a review from a team as a code owner October 20, 2023 22:32
@superskip
Copy link
Contributor

  • We now cache both network calls and user sessions, which should greatly improve performance (at least it does locally)

Sounds awesome 😄

Copy link
Contributor

@simonadomnisoru simonadomnisoru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@@ -1,5 +1,7 @@
Feature: Breaking the glass page

# TODO - Flaky tests should be fixed by TECH-1662
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you merge the PR, can you add this test and ticket to the Cypress tests wiki? Thanks!

Given you land on a main page with an invalid program id
Then you should see error message
# TODO - App crashes on invalid program id (DHIS2-16010)
# Scenario: Main page > Url with invalid program id
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same reminder about this scenario. Thanks!

Copy link
Member

@JoakimSM JoakimSM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@eirikhaugstulen eirikhaugstulen merged commit b1c1f1a into master Oct 26, 2023
35 of 36 checks passed
@eirikhaugstulen eirikhaugstulen deleted the eh/TECH/upgrade_cypress_v12 branch October 26, 2023 08:57
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 100.43.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants