fix: [DHIS2-15633] Change comment to note #3549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ChangeCommentToNote
henrikmv
changed the title
|
Thanks for the reminder about the docs @simonadomnisoru. I did an update for the documentation in PR #3649 |
simonadomnisoru
approved these changes
May 27, 2024
|
🚀 Deployed on https://deploy-preview-3549--dhis2-capture.netlify.app |
geethaalwan
approved these changes
Jun 3, 2024
|
After discussions with @JoakimSM, I have also changed from comment to note in code. |
simonadomnisoru
approved these changes
Jul 1, 2024
There was a problem hiding this comment.
Hi @henrikmv,
Good job 🥳 ! I just added a small comment. In addition to this, I was wondering if it would make sense to run this ticket through some QA regression testing again (given that the change in the codebase is quite large), WDYT?
Thanks!
...es/capture-core/components/WidgetStagesAndEvents/Stages/Stage/StageDetail/Notes.component.js
Outdated
Show resolved
Hide resolved
src/core_modules/capture-core/components/Notes/Notes.component.js
Outdated
Show resolved
Hide resolved
simonadomnisoru
approved these changes
Jul 10, 2024
|
LGTM from QA perspective and recheck |
dhis2-bot
added a commit
that referenced
this pull request
Jul 15, 2024
## [100.70.11](v100.70.10...v100.70.11) (2024-07-15) ### Bug Fixes * [DHIS2-15633] Change comment to note ([#3549](#3549)) ([56ea017](56ea017))
|
🎉 This PR is included in version 100.70.11 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DHIS2-15633