Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [DHIS2-17171] preview images in versions prior to 41 #3694

Merged
merged 3 commits into from
Aug 8, 2024
Merged

feat: [DHIS2-17171] preview images in versions prior to 41 #3694

merged 3 commits into from
Aug 8, 2024

Conversation

simonadomnisoru
Copy link
Contributor

@simonadomnisoru simonadomnisoru commented Jun 27, 2024 •
edited by jira bot
Loading

DHIS2-17171

Tech summary

  • preview images in versions prior to 41 in all 3 working lists, Profile widget, StagesAndEvents widget, and the search results card
  • the request to /fileResource for DE or TEA of type IMAGE is no longer needed and was removed

@simonadomnisoru simonadomnisoru requested a review from a team as a code owner June 27, 2024 12:34
JoakimSM
JoakimSM reviewed Jul 1, 2024
View reviewed changes
Copy link
Member

@JoakimSM JoakimSM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just had a quick look, so might be mistaken, but I think we currently have to do the request for versions prior to 41 (as we are using the filename for those version)? I'm fine with implementing https://dhis2.atlassian.net/browse/DHIS2-17171 first though.

@simonadomnisoru simonadomnisoru marked this pull request as draft July 8, 2024 05:59
@simonadomnisoru simonadomnisoru changed the title fix: [DHIS2-17538] skip the fileResource request for image feat: [DHIS2-17171] preview images in versions prior to 41 Jul 10, 2024
@simonadomnisoru
Copy link
Contributor Author

simonadomnisoru commented Jul 10, 2024 •
edited
Loading

Just had a quick look, so might be mistaken, but I think we currently have to do the request for versions prior to 41 (as we are using the filename for those version)? I'm fine with implementing https://dhis2.atlassian.net/browse/DHIS2-17171 first though.

Hey @JoakimSM,
I added the implementation for DHIS2-17171 to this branch. With this change, the request to /fileResource is no longer needed for all versions. Can you have a look?
Thanks!

@simonadomnisoru simonadomnisoru marked this pull request as ready for review July 10, 2024 09:59
@simonadomnisoru simonadomnisoru requested review from JoakimSM and a team July 10, 2024 09:59
JoakimSM
JoakimSM approved these changes Aug 7, 2024
View reviewed changes
Copy link
Member

@JoakimSM JoakimSM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 7, 2024

🚀 Deployed on https://deploy-preview-3694--dhis2-capture.netlify.app

geethaalwan
geethaalwan approved these changes Aug 8, 2024
View reviewed changes
Copy link

@geethaalwan geethaalwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested successfully on 2.40.5,2.39.7 versions

@simonadomnisoru simonadomnisoru merged commit 2f51805 into master Aug 8, 2024
50 checks passed
@simonadomnisoru simonadomnisoru deleted the DHIS2-17538 branch August 8, 2024 11:56
dhis2-bot added a commit that referenced this pull request Aug 8, 2024
@dhis2-bot
chore(release): cut 100.76.0 [skip release]
55ff94e 
# [100.76.0](v100.75.1...v100.76.0) (2024-08-08)

### Features

* [DHIS2-17171] preview images in versions prior to 41 ([#3694](#3694)) ([2f51805](2f51805))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 100.76.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoakimSM JoakimSM JoakimSM approved these changes

@geethaalwan geethaalwan geethaalwan approved these changes

Assignees
No one assigned
Labels
released testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@simonadomnisoru @dhis2-bot @JoakimSM @geethaalwan