-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: [DHIS2-17736] Dropdown Regression in Registration Form #3710
fix: [DHIS2-17736] Dropdown Regression in Registration Form #3710
Conversation
@@ -15,6 +15,7 @@ const getStyles = theme => ({ | |||
containerCustomForm: { | |||
paddingTop: 10, | |||
paddingBottom: 10, | |||
overflowX: 'scroll', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you checked if there are any difference between overflow-scroll and overflow-auto here? To my knowledge, scroll
always puts on a scroll bar, even though the form is not overflowing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, @eirikhaugstulen! I have changed to overflowX: 'auto'
🚀 Deployed on https://deploy-preview-3710--dhis2-capture.netlify.app |
LGTM from QA perspective |
## [100.70.10](v100.70.9...v100.70.10) (2024-07-15) ### Bug Fixes * [DHIS2-17736] Dropdown Regression in Registration Form ([#3710](#3710)) ([4c46276](4c46276))
🎉 This PR is included in version 100.70.10 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
DHIS2-17736