feat: [DHIS2-16125] hide program stage under certain circumstances #3735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/core_modules/capture-core/components/WidgetStagesAndEvents/Stages/Stage/Stage.component.js
Outdated
Show resolved
Hide resolved
src/core_modules/capture-core/components/WidgetStagesAndEvents/Stages/Stage/Stage.component.js
Outdated
Show resolved
Hide resolved
|
Thank you for the review, @simonadomnisoru! I have committed the changes suggested now |
simonadomnisoru
approved these changes
Jul 29, 2024
|
@simonadomnisoru, I had a Cypress test breaking because the test was looking for a disabled button in a stage that is now hidden due to the changes implemented in this branch. Do you also want to look at the Cypress changes? Thank you! |
|
🚀 Deployed on https://deploy-preview-3735--dhis2-capture.netlify.app |
geethaalwan
approved these changes
Aug 6, 2024
henrikmv
deleted the
hv/feat/DHIS2-16125_HideProgramStageUnderCertainCircumstances
branch
dhis2-bot
added a commit
that referenced
this pull request
Aug 7, 2024
# [100.73.0](v100.72.0...v100.73.0) (2024-08-07) ### Features * [DHIS2-16125] hide program stage under certain circumstances ([#3735](#3735)) ([c6b6dc0](c6b6dc0))
|
🎉 This PR is included in version 100.73.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DHIS2-16125
Prevent adding new events to stageis in effect when no events are in stage. If so, the program stage is hidden.ConditionalTooltipanddisabledprop for the scenario where there are no events, because there are no use cases where this button can be disabled.