build: remove react-scripts 4.0.3 resolution #3739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 This PR is included in version 100.71.3 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request upgrades Capture app to use the latest version of react-scripts (5.0.1).
The main motivation behind doing this upgrade is that the new kotlin rule engine has difficulties "importing named exports from non EcmaScript modules" when using react-scripts 4.0.3.
One side effect of upgrading react-scripts is that the
processobject becomes inaccessible to Capture, except one propertyprocess.env, which gets injected with an explicit value during compilation. The other uses of theprocessobject had to be removed.Another side effect was that it enabled the app to make use of package export aliases, but apparently also requiring it to do so. Consequently a few explicitly given paths in the app had to be modified.
The changes in
.eslintrcand.flowconfigwere made to fix a couple of linter and flow errors related to import paths.