Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: [DHIS2-17826] Replace Material UI Chip #3741

Merged
merged 2 commits into from
Aug 7, 2024
Merged

refactor: [DHIS2-17826] Replace Material UI Chip #3741

merged 2 commits into from
Aug 7, 2024

Conversation

henrikmv
Copy link
Contributor

@henrikmv henrikmv commented Aug 2, 2024 •
edited
Loading

DHIS2-17826

  • Used the Chip component from the DHIS2/UI library, but removed the hover and set pointer to default.
  • Fixed overflow
  • Note: Chip is oval, not circular after the change

@henrikmv henrikmv marked this pull request as ready for review August 2, 2024 15:52
@henrikmv henrikmv requested a review from a team as a code owner August 2, 2024 15:52
simonadomnisoru
simonadomnisoru approved these changes Aug 5, 2024
View reviewed changes
Copy link
Contributor

@simonadomnisoru simonadomnisoru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 5, 2024

🚀 Deployed on https://deploy-preview-3741--dhis2-capture.netlify.app

geethaalwan
geethaalwan approved these changes Aug 6, 2024
View reviewed changes
Copy link

@geethaalwan geethaalwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested successfully on 2.42,2.41.1,2.40.5,2.39.7 versions

@henrikmv henrikmv merged commit 75fef63 into master Aug 7, 2024
71 checks passed
@henrikmv henrikmv deleted the hv/feat/DHIS2-17826_ReplaceMaterialUiChip branch August 7, 2024 08:05
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 100.73.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonadomnisoru simonadomnisoru simonadomnisoru approved these changes

@geethaalwan geethaalwan geethaalwan approved these changes

Assignees
No one assigned
Labels
e2e-tests released testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@henrikmv @dhis2-bot @simonadomnisoru @geethaalwan