-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: [DHIS2-16010] app crashes on invalid programid #3765
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @alaa-yahia,
Along with this fix, let's enable the related disabled cypress scenario. Additionally, is it possible to add another scenario for the enrollment page too?
Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @alaa-yahia!
If you try to change to an invalid enrollmentId or teiId with this change, it seems like it's stuck in a loading state? Could you have a look at this? 😊 I also struggle a bit when using enrollmentId=AUTO after this change, but it seems a bit more sporadic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! 🎉
Hey @eirikhaugstulen I have updated the code. |
Hi @eirikhaugstulen, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @alaa-yahia - so sorry for taking such a long time before getting back to you. It must have gone over my head. Feel free to ping me directly if you're blocked in the future. This looks good now 🎉
I forgot all about it either @eirikhaugstulen, otherwise I would have pinged you! No worries at all about the delay. Thank you for the review. |
🚀 Deployed on https://deploy-preview-3765.capture.netlify.dhis2.org |
Implements DHIS2-16010
programId
||orgUnitId
is invalid.withErrorMessageHandler
to use DHIS2 UINoticeBox
of typeerror
Enrollment Page
EnrollmentEventNew Page
Main Page:
New Page