feat: [DHIS2-17956] Display name for org unit in changelog #3826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/feat/DHIS2-17771_OrgUnitContextInTablesAndLists
…/feat/DHIS2-17956_DisplayNameForOrgUnitInChangelog
…/feat/DHIS2-17956_DisplayNameForOrgUnitInChangelog
simonadomnisoru
approved these changes
Oct 14, 2024
| @@ -88,9 +87,10 @@ function convertStatusForDisplay(clientValue: Object) { | |||
| ); | |||
| } | |||
|
|
|||
| function convertOrgUnitForDisplay(clientValue: { id: string }) { | |||
| function convertOrgUnitForDisplay(clientValue: string | Object) { | |||
There was a problem hiding this comment.
NIT: improve the flow type clientValue: string | {id: string}
|
🚀 Deployed on https://deploy-preview-3826.capture.netlify.dhis2.org |
geethaalwan
approved these changes
Oct 15, 2024
henrikmv
deleted the
hv/feat/DHIS2-17956_DisplayNameForOrgUnitInChangelog
branch
dhis2-bot
added a commit
that referenced
this pull request
Oct 15, 2024
# [101.12.0](v101.11.2...v101.12.0) (2024-10-15) ### Features * [DHIS2-17956] Display name for org unit in changelog ([#3826](#3826)) ([5299f37](5299f37))
|
🎉 This PR is included in version 101.12.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DHIS2-17956:
clientValueis submitted as a string or an object. From the changelog, the variable is sent as a string, but before these changes, the converting function only expected to get in an object withid