Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [DHIS2-17978] use title instead of alt on missing icons #3847

Conversation

eirikhaugstulen
Copy link
Contributor

Tech-summary:

  • Use title instead of alt on missing icons

@eirikhaugstulen eirikhaugstulen marked this pull request as ready for review October 14, 2024 19:31
@eirikhaugstulen eirikhaugstulen requested a review from a team as a code owner October 14, 2024 19:31
Copy link

Copy link

@geethaalwan geethaalwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested successfully on 2.42, 2.41.2 versions

@eirikhaugstulen eirikhaugstulen merged commit b5940f2 into master Oct 16, 2024
39 checks passed
@eirikhaugstulen eirikhaugstulen deleted the eh/fix/DHIS2-17978-use-title-instead-of-alt-on-missing-icons branch October 16, 2024 12:52
dhis2-bot added a commit that referenced this pull request Oct 16, 2024
## [101.12.1](v101.12.0...v101.12.1) (2024-10-16)

### Bug Fixes

* [DHIS2-17978] use title instead of alt on missing icons ([#3847](#3847)) ([b5940f2](b5940f2))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 101.12.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

eirikhaugstulen added a commit that referenced this pull request Oct 17, 2024
* fix: use title instead of alt on missing icons

* chore: fix failing tests
eirikhaugstulen pushed a commit that referenced this pull request Oct 17, 2024
## [101.12.1](v101.12.0...v101.12.1) (2024-10-16)

### Bug Fixes

* [DHIS2-17978] use title instead of alt on missing icons ([#3847](#3847)) ([b5940f2](b5940f2))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants