feat: improve copy/past text [DHIS2-15012] #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomzemp
commented
Mar 28, 2023
| @@ -21,15 +21,15 @@ import styles from './success-content.module.css' | |||
| const importTypeConfig = { | |||
| imported: { | |||
| style: 'success', | |||
| text: i18n.t('Imported'), | |||
| text: i18n.t('imported'), | |||
There was a problem hiding this comment.
the change here is not related to the main purpose of the ticket, but I noticed incorrect translations when adding/checking translations for this ticket. Lowercasing the translation did not appear to work here, so instead the translation strings in lower-case form are added directly
tomzemp
commented
Mar 28, 2023
| @@ -25,15 +26,15 @@ const submitReducer = (state, action) => { | |||
| error: null, | |||
| loading: false, | |||
| called: true, | |||
| dataSubmitted: true, | |||
| dataSubmitted: moment().format(), | |||
There was a problem hiding this comment.
dataSubmitted is changed from a boolean (has data been submitted) to a string (when the data was submitted, for use in the clipboard text)
|
🚀 Deployed on https://pr-63--dhis2-data-exchange.netlify.app |
geethaalwan
approved these changes
Aug 28, 2023
dhis2-bot
added a commit
that referenced
this pull request
Aug 28, 2023
# [100.1.0](v100.0.6...v100.1.0) (2023-08-28) ### Features * improve copy/past text [DHIS2-15012] ([#63](#63)) ([00469ca](00469ca))
|
🎉 This PR is included in version 100.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See DHIS2-15012 for information about this ticket.
Changes the clipboard text from a simple CSV output
to more detailed text output (which includes conflicts where relevant):