test: add tests for totals/cumulative with mixed valueTypes/totalAggr…

…egationTypes
dhis2 · Oct 18, 2024 · 09d9d43 · 09d9d43
1 parent 0607288
commit 09d9d43
Show file tree

Hide file tree

Showing 3 changed files with 118 additions and 1 deletion.
diff --git a/cypress/elements/optionsModal/totals.js b/cypress/elements/optionsModal/totals.js
@@ -1,6 +1,6 @@
 export const colTotalsOptionEl = 'option-col-totals'
 const colSubTotalsOptionEl = 'option-col-subtotals'
-const rowTotalsOptionEl = 'option-row-totals'
+export const rowTotalsOptionEl = 'option-row-totals'
 const rowSubTotalsOptionEl = 'option-row-subtotals'
 
 export const expectColumnsTotalsToBeDisabled = () =>

diff --git a/cypress/integration/options/cumulativeValues.cy.js b/cypress/integration/options/cumulativeValues.cy.js
@@ -17,7 +17,10 @@ import { checkCheckbox, uncheckCheckbox } from '../../elements/common.js'
 import {
     clickDimensionModalHideButton,
     clickDimensionModalUpdateButton,
+    clearSearchTerm,
+    inputSearchTerm,
     selectDataElements,
+    selectDataItems,
     selectFixedPeriods,
     unselectAllItemsByButton,
 } from '../../elements/dimensionModal/index.js'
@@ -33,17 +36,20 @@ import {
 } from '../../elements/optionsModal/index.js'
 import {
     colTotalsOptionEl,
+    rowTotalsOptionEl,
     expectColumnsTotalsToBeChecked,
     expectColumnsTotalsToBeDisabled,
     expectColumnsSubTotalsToBeDisabled,
     expectRowsTotalsToBeDisabled,
     expectRowsSubTotalsToBeDisabled,
     expectColumnsTotalsToBeEnabled,
     expectColumnsSubTotalsToBeEnabled,
+    expectRowsTotalsToBeChecked,
     expectRowsTotalsToBeEnabled,
     expectRowsSubTotalsToBeEnabled,
 } from '../../elements/optionsModal/totals.js'
 import {
+    expectTableToBeVisible,
     expectTableValueCellToContainValue,
     clickTableHeaderCell,
 } from '../../elements/pivotTable.js'
@@ -217,5 +223,58 @@ describe('Options - Cumulative values', () => {
             expectTableValueCellToContainValue(2, '18 000')
             expectTableValueCellToContainValue(5, '18 488')
         })
+
+        it('accumulates for numeric/boolean value types with totalAggregationType SUM skipping other values', () => {
+            openDimension(DIMENSION_ID_DATA)
+
+            inputSearchTerm('ANC')
+            selectDataItems(['ANC 1st visit', 'ANC 2nd visit'])
+            clearSearchTerm()
+            inputSearchTerm('Coverage')
+            selectDataItems(['ANC 1 Coverage'])
+            clearSearchTerm()
+            inputSearchTerm('Cholera')
+            selectDataItems(['Cholera (Deaths < 5 yrs) Narrative'])
+            clearSearchTerm()
+            inputSearchTerm('ANC')
+            selectDataItems([
+                'ANC 3rd visit',
+                'ANC 2 Coverage',
+                'ANC 4th or more visits',
+            ])
+            clearSearchTerm()
+            inputSearchTerm('Child')
+            selectDataItems([
+                'Child Health - Reporting rate',
+                'Child Programme MCH Apgar Score',
+            ])
+            clearSearchTerm()
+            inputSearchTerm('BCG')
+            selectDataItems(['BCG doses'])
+            clickDimensionModalHideButton()
+
+            const year = new Date().getFullYear().toString()
+            openDimension(DIMENSION_ID_PERIOD)
+            unselectAllItemsByButton()
+            selectFixedPeriods([`October ${year}`], 'Monthly')
+
+            clickDimensionModalHideButton()
+
+            openOptionsModal(OPTIONS_TAB_DATA)
+            checkCheckbox(cumulativeValuesOptionEl)
+
+            clickOptionsModalUpdateButton()
+
+            expectTableToBeVisible()
+
+            expectTableValueCellToContainValue(1, '37 765')
+            expectTableValueCellToContainValue(2, '89.75')
+            expectTableValueCellToContainValue(4, '52 407')
+            expectTableValueCellToContainValue(5, '88.93')
+            expectTableValueCellToContainValue(6, '61 333')
+            expectTableValueCellToContainValue(7, '71.54')
+            expectTableValueCellToContainValue(8, '61 333.98')
+            expectTableValueCellToContainValue(9, '61 664.98')
+        })
     })
 })
diff --git a/cypress/integration/options/totals.cy.js b/cypress/integration/options/totals.cy.js
@@ -12,6 +12,7 @@ import {
     clickDimensionModalUpdateButton,
     expectDimensionModalToBeVisible,
     inputSearchTerm,
+    clearSearchTerm,
     selectAllItemsByButton,
     selectDataElements,
     selectDataItems,
@@ -31,7 +32,9 @@ import {
 } from '../../elements/optionsModal/index.js'
 import {
     colTotalsOptionEl,
+    rowTotalsOptionEl,
     expectColumnsTotalsToBeChecked,
+    expectRowsTotalsToBeChecked,
 } from '../../elements/optionsModal/totals.js'
 import {
     expectTableToBeVisible,
@@ -113,3 +116,58 @@ describe('Options - Column totals', () => {
         })
     })
 })
+
+describe('Options - Row totals', () => {
+    describe('Totals with mixed valueType/totalAggregationType', () => {
+        it('shows N/A when values along the row cannot be summed', () => {
+            goToStartPage()
+            changeVisType(visTypeDisplayNames[VIS_TYPE_PIVOT_TABLE])
+
+            openOptionsModal(OPTIONS_TAB_DATA)
+            checkCheckbox(rowTotalsOptionEl)
+
+            expectRowsTotalsToBeChecked()
+
+            clickOptionsModalHideButton()
+
+            openDimension(DIMENSION_ID_DATA)
+
+            inputSearchTerm('ANC')
+            selectDataItems(['ANC 1st visit', 'ANC 2nd visit'])
+            clearSearchTerm()
+            inputSearchTerm('Coverage')
+            selectDataItems(['ANC 1 Coverage'])
+            clearSearchTerm()
+            inputSearchTerm('Cholera')
+            selectDataItems(['Cholera (Deaths < 5 yrs) Narrative'])
+            clearSearchTerm()
+            inputSearchTerm('ANC')
+            selectDataItems([
+                'ANC 3rd visit',
+                'ANC 2 Coverage',
+                'ANC 4th or more visits',
+            ])
+            clearSearchTerm()
+            inputSearchTerm('Child')
+            selectDataItems([
+                'Child Health - Reporting rate',
+                'Child Programme MCH Apgar Score',
+            ])
+            clearSearchTerm()
+            inputSearchTerm('BCG')
+            selectDataItems(['BCG doses'])
+            clickDimensionModalHideButton()
+
+            const year = new Date().getFullYear().toString()
+            openDimension(DIMENSION_ID_PERIOD)
+            unselectAllItemsByButton()
+            selectFixedPeriods([`October ${year}`], 'Monthly')
+
+            clickDimensionModalUpdateButton()
+
+            expectTableToBeVisible()
+
+            expectTableValueCellToContainValue(10, 'N/A')
+        })
+    })
+})